Bug#745152: lintian: missing source / prebuilt-javascript-object deployJava.js

[Felix Natter <fnatter@gmx.net>]

Bastien ROUCARIES <roucaries.bastien@gmail.com> writes:

> On Sun, Apr 20, 2014 at 5:53 PM, Felix Natter <fnatter@gmx.net> wrote:
>> Bastien ROUCARIES <roucaries.bastien@gmail.com> writes:
>>
>>> Le 18 avr. 2014 15:51, "Felix Natter" <fnatter@gmx.net> a écrit :
>>>>
>>>>
>>>> Package: lintian
>>>> Version: 2.5.22.1
>>>> Severity: important
>>>>
>>>> Dear Maintainer,
>>>>
>>>> my Freeplane package (draft for new upstream version here:
>>>> https://github.com/fnatter/freeplane-debian/) includes deployJava.js for
>>>> the applet export (in order to avoid network access to
>>>> 'http://www.java.com/js/deployJava.js' for _local_ applets).
>>>>
>>>> Now I get these two lintians:
>>>>
>>>> E: freeplane source: source-is-missing freeplane/resources/html/deployJava.js
>>>> P: freeplane source: source-contains-prebuilt-javascript-object freeplane/resources/html/
>>> deployJava.js mean line length is about 15764 characters
>>>>
>>>> Next I included the source (BSD-3-clause license):
>>>>   https://github.com/fnatter/freeplane-debian/blob/master/freeplane/resources/html/deployJava.txt
>>>> in the same directory as deployJava.js:
>>>>   https://github.com/fnatter/freeplane-debian/blob/master/freeplane/resources/html/deployJava.js
>>>>
>>>> --> is lintian looking for "deployJava.txt" as source of "deployJava.js"?
>>>> (deployJava.txt seems to be a common name for this:
>>>> http://www.java.com/js/deployJava.txt)
>>>>
>>>> (I'd like to avoid putting it into debian/missing-sources because it's
>>>> already in freeplane/resources/html)
>>
>> hi Bastien,
>>
>>> Will add needed code. Thanks d'or thé bug report.
>>
>> Ok, thanks for the quick reply and action :-)
>>
>>> Btw does deployjava is already packaged?
>>
>> I don't think so, and I hesitate to package it separately because I
>> would have to create that package and patch freeplane :-/

hi Bastien,

> You could only open a RFP

Still then I would have to patch freeplane not to use the version in
"freeplaneeditor.jar" and use sth like /usr/share/deployJava.js instead.

And it won't help most other packages, because they usually just
reference 'http://www.java.com/js/deployJava.js'. (freeplane doesn't do
this in order to avoid network accesses for local applets).

>>> Bastien
>>>>
>>>> --> Can we suppress the 'source-contains-prebuilt-javascript-object' warning
>>>> for "deployJava.js" or shall I override it?
>>
>> Concerning this: Shall I add an override or does your lintian code
>> change take this into account?
>
> As you wish I will change the code. If you need sponsorship add link
> tothis bug report.

Great, thanks.

Cheers and Best Regards,
-- 
Felix Natter