Hi Colin,
Colin King (gmail) <colin.i.king@gmail.com> ezt írta (időpont: 2023.
nov. 7., K, 15:18):
Hi Balint,
Thanks for responding with the review. I was waiting for the upstream
project to release a 0.4 with some minor fixes before re-uploading to
mentors.
I've addressed the issues you found as below:
Please see my observations below.
On 22/10/2023 22:38, Bálint Réczey wrote:
Hi Colin,
I've checked the second upload at [1].
As you can see in the Lintian warnings there is a .git directory which
is not ideal for a source package.
I suggest using the most widely used git-buildpackage based workflow
where the gbp command takes care of exporting the source package
without the .git dir from the packaging repository.
I'd be happy to set up a packaging repo for you at
https://salsa.debian.org/debian/libtypec and add you as a maintainer
as described in [2]
I still hold up my offer about setting up a git repo for packaging on
Salsa. That comes with the benefit of automated fixes from Debian
Janitor and I could also comment on changes right where they happened.
Other observations regarding the packaging:
* There is debian/install and also there are binary package specific
*.install files which is slightly confusing.
I suggest dropping debian/install.
Fixed
* In the debian/*.install files you need to specify only the target
dir, not the target file.
Fixed
In libtypec-dev
/usr/share/pkgconfig/${DEB_HOST_MULTIARCH}/libtypec.pc/libtypec.pc
gets shipped, which is not desired.
Fixed
I think my comment here was misleading, sorry for that.
Shipping *.pc is desired, shipping it in the .../libtypec.pc/ dir as a
result of specifying .../libtypec.pc as the target dir in the .install
file was not desired. It was even patched to have the right content.
Please ship the .pc file in the -dev package.
* libtypec.h seems to be the same on all architectures. Does it have
to be shipped in a multiarch include location?
Fixed. Now in /usr/include and in the multiarch include location
* Binary packages in debian/control are not marked as Multi-Arch: same
* Please target experimental. The package needs to pass NEW and to
migrate to testing it will need a new source-only upload anyway.
Fixed.
Please review the 0.4 release upload and let me know if this can be
sponsored further to the changes I made.
* Both libtypec-dev.install and libtypec1.install lists
usr/lib/${DEB_HOST_MULTIARCH} and as a result both packages ship the
*.so symlink and *.so.0.4.0.
Please ship *.so.0.4.0 in the library package and the *.so symlink in
the -dev package only.