Hello, On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have > also filed an RFS bug#1053987. Alright, pushed that to a team repo, let's work from there. Review of 8123e6e09fa1591dc2182682661421d9be80c328: - d/copyright is required to say where upstream sources were obtained -- see Debian Policy - It looks like you made up the copyright statement for Wilfred Hughes, right? While he may indeed hold copyright, what the GPL requires is just that we reproduce the copyright notices we actually find in the source. So it's probably best to drop it for now, and consider offering a pull request upstream. - I'd like to suggest dropping the .gitignore, because it interferes with me uploading using dgit. Can explain more if you want. - description "electric support" is ambiguous. Support for doing what? - in general, do you mind if when I upload I commit the 'dch -r' change for you? I.e. the upload is signed off by me, but there'd be [ Xiyue Deng ] in the changelog. This avoids an e-mail roundtrip. Totally up to you. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature