Bug#896186: RFS: netctl/1.16-1 [ITP]

[Lumin <cdluminate@gmail.com>]

Hi Yangfl,

Some feedbacks after checking you package:

1. Vcs-* fields are missing, which makes it hard to track
    the changes. I'd recommend you to put the packaging
    work on salsa or somewhere alike.

2. lintian overrides: why do you override them? Please add
   the explanation as comments in the override file.

3. Please remove empty directories under debian/ .

4. Patch headers are missing. Please add at least these information
   to the head part of patches: Author, Purpose, Forward-Upstream(bool).

5. It is funny to harden some bash scripts.
    export DEB_BUILD_MAINT_OPTIONS = hardening=+all
    This line is useless and removing it from rules won't harm.

6. export DEB_CFLAGS_MAINT_APPEND  = -Wall -pedantic
    export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed

    Same above. These lines are useless.

7. in rules:
     14 build:
     15 ⋅⋅⋅⋅# pass

    Well .... what's this?

8. [important] It FTBFS'ed on my machine. Do you have debomatic-amd64
    access?


Please feel free to ask if you have any question about these points :-)

-- 
Best,