Bug#802399: RFS: localehelper/0.1.4-1 [ITP] - Locale helper tool

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Control: owner -1 !

Hi,

the upstream packaging is obviously good :)

lets review:

- please run wrap-and-sort
- please use "tab" in your rules file (vim is showing them really bad)

- usually when I override dh_auto_target: I do it this way
override_dh_auto_foo:
    $(MAKE) something
    dh_auto_foo

even if in your case they do nothing, but in the future upstream might include a Makefile
or something else, so they will start do something useful.

Otherwise your package will become broken (specially when you miss something to build)



please ping me once you have addressed the above.

I'm not sure the package will pass the reproducibly test, but well, we will see ;)

cheers,

G.

Il Mercoledì 21 Ottobre 2015 16:39, Jakub Wilk <jwilk@debian.org> ha scritto:
* Jonathan Horn <info@autoit4you.de>, 2015-10-20, 23:16:
>>Hmm, was ITP bug CCed to debian-devel? I didn't see it there...
>As far as I know no, for some reason. Maybe I didn't submitted it the 
>right way? (I used reportbug)

That's odd, reportbug should have taken care of that...
It should have also set yourself as the bug owner, but it didn't.


-- 
Jakub Wilk