Bug#729534: RFS: libpoly2tri/0.3.3-1 [ITP]
On 2013-11-14 00:32, Bryan Conrad wrote:
> I am looking for a sponsor for my package "libpoly2tri"
I'm not a DD so I cannot sponsor your package, but hoping that you are
still interested in contributing to Debian (despite the long time passed
since your ITP) I'd like to offer some feedback.
debian/changelog
================
In the get-orig-source target of debian/rules, you are removing a file
from the original upstream source. This fact should be reflected in the
upstream version number, usually by appending a +dfsg (indicating that
the motive was DFSG-cleaning).
But TBH, I'd skip removing the file entirely and instead keep the
upstream source as-is. See debian/copyright and debian/rules below.
> * This is my first Debian package
I'd drop this line, as while commendable :-), it does not really
describe a change.
debian/control
==============
Build-Depends: debhelper (>= 9) instead of (>= 9.0.0)
Standards-Version can be updated to 3.9.5
Regarding the package description: I'd lowercase the synopsis and
possibly reconsider the structure of the description. There's nothing
wrong with your approach, but one popular approach I'd like to point out
is for the binary packages to share a common first paragraph and then
differentiate in the second paragraph. libssh2-1 and libssh2-1-dev are
good examples. But again, this is just a matter of taste.
debian/copyright
================
The proper shortname for the license is BSD-3-clause.
I'd add the Upstream-Contact: field to the header section with the
author you specified in the ITP
If you add another Files: section for the "waf" file you're removing in
the get-orig-source target, also with License: BSD-3-clause but with a
different Copyright:, then you can avoid the hassle of removing it,
because it too is licensed under that license.
If you do perform DFSG cleaning, a brief explanation of what/why in the
form of a Comment: field in the header section would be nice.
Whilst there is nothing wrong in licensing your packaging in debian/*
under the GPL-2+, I'd consider licensing debian/patches/* under the
BSD-3-clause so that any patches you might create can easily be included
upstream.
debian/watch
============
Upstream apparently doesn't provide tarballs or even tags in the
mercurial repo, but upstream does use version numbers (you evidently
found the 0.3.3 in "wscript"). So I'd politely ask upstream to remedy
this by at least tagging a 0.3.3.
This would simplify quite a few things for you. For one thing, you could
drop the (by necessity, I know) very hacky get-orig-source target in
favor of uscan.
debian/rules
============
You don't really need to remove the waf file, provided you document its
copyright in debian/copyright.
When repacking the source, consider using xz (-J) instead of gzip (-z).
Hardcoding $HASH.zip and the 0.3.3 version is not really pretty but I
guess that can't be avoided unless upstream agrees to tag a release.
debian/libpoly2tri0.3.symbols
=============================
This is problematic. First, you need to demangle the symbols in there
with c++filt (for examples, your package FTBFS on my host without this). See
https://wiki.debian.org/UsingSymbolsFiles
at the bottom on how to do this.
But as you will also see from that page, symbols files for C++ can be
quite a hassle and maybe even not worth it, so you might consider
dropping it all together.
debian/patches
==============
Consider supplementing your patches with DEP3-headers, see
http://dep.debian.net/deps/dep3/
README.source
=============
This is apparently the example README.source. If you don't need to it,
remove it.
debian/source.lintian-overrides
===========
This file should actually be called debian/source/lintian-overrides.
HTH,
Christian
>
> * Package name : libpoly2tri
> Version : 0.3.3-1
> Upstream Author : Mason Green <mason.green@gmail.com>
> * URL : http://code.google.com/p/poly2tri/
> * License : BSD
> Section : libs
>
> It builds those binary packages:
>
> libpoly2tri-dev - Development headers for libpoly2tri
> libpoly2tri0.3 - Lightweight triangulation library for simple polygons
>
> To access further information about this package, please visit the following URL:
>
> http://mentors.debian.net/package/libpoly2tri
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/libp/libpoly2tri/libpoly2tri_0.3.3-1.dsc
>
> More information about libpoly2tri can be obtained from http://code.google.com/p/poly2tri/.
>
Reply to: