Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
* Jakub Wilk <jwilk@debian.org>, 2013-01-11, 21:20:
> * Giulio Paci <giuliopaci@gmail.com>, 2013-01-04, 18:39:
>>>As far as I can see, the test scripts create temporary files in an
>>>insecure way.
>>The scripts do not interfere each other. Instead of patching them, I
>>defined TMPDIR to tmpdata, so that the temporary files are created in
>>the package build directory.
>
> That's okay for us, but please forward the bug upstream; they should fix
> it too.
Reported.
> The package needs the OpenFST far extensions, which were not enabled in
> Debian until recently. It would be nice to make the libfst-dev
> build-dependency versioned.
Done.
> Would it be possible to exclude binary files from the being analysed by
> licensecheck?
Done.
> Is there a reason you explicitly enable building static libraries?
Just to mimic openfst.
But I have to say that openfst upstream suggests static libraries for performance reasons, while opengrm-ngram upstream suggests no static libraries for compilation speed
reasons.
Do you prefer if I drop the static libraries?
> src/include/ngram/ngram.h doesn't look like valid C++ to me...
Fixed.
> Typo in src/bin/ngraminfo.cc: modesl -> models.
Fixed.
Bests,
Giulio.
Reply to: