Re: [PATCH 07/17] nbd: call blk_mark_disk_dead in nbd_clear_sock_ioctl
- To: Samuel Holland <samuel.holland@sifive.com>
- Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Jens Axboe <axboe@kernel.dk>, Denis Efremov <efremov@linux.com>, Josef Bacik <josef@toxicpanda.com>, Stefan Haberland <sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, "Darrick J . Wong" <djwong@kernel.org>, Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
- Subject: Re: [PATCH 07/17] nbd: call blk_mark_disk_dead in nbd_clear_sock_ioctl
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 25 Sep 2023 09:48:38 +0200
- Message-id: <[🔎] 20230925074838.GA28522@lst.de>
- In-reply-to: <79af9398-167f-440e-a493-390dc4ccbd85@sifive.com>
- References: <20230811100828.1897174-1-hch@lst.de> <20230811100828.1897174-8-hch@lst.de> <79af9398-167f-440e-a493-390dc4ccbd85@sifive.com>
On Wed, Sep 20, 2023 at 03:41:11PM -0500, Samuel Holland wrote:
> [ 14.619101] Buffer I/O error on dev nbd0, logical block 0, async page read
>
> [ 14.630490] nbd0: unable to read partition table
>
> I wonder if disk_force_media_change() is the right thing to call here instead.
So what are the semantics of clearing the socket?
The <= 6.5 behavior of invalidating fs caches, but not actually marking
the fs shutdown is pretty broken, especially if this expects to resurrect
the device and thus the file system later on.
Reply to: