Re: [PATCH 03/17] btrfs: call btrfs_close_devices from ->kill_sb
- To: Christoph Hellwig <hch@lst.de>
- Cc: Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>, Denis Efremov <efremov@linux.com>, Josef Bacik <josef@toxicpanda.com>, Stefan Haberland <sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, "Darrick J . Wong" <djwong@kernel.org>, Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
- Subject: Re: [PATCH 03/17] btrfs: call btrfs_close_devices from ->kill_sb
- From: Christian Brauner <brauner@kernel.org>
- Date: Fri, 11 Aug 2023 14:03:29 +0200
- Message-id: <[🔎] 20230811-randlage-kreis-288a41a139fb@brauner>
- In-reply-to: <[🔎] 20230811100828.1897174-4-hch@lst.de>
- References: <[🔎] 20230811100828.1897174-1-hch@lst.de> <[🔎] 20230811100828.1897174-4-hch@lst.de>
On Fri, Aug 11, 2023 at 12:08:14PM +0200, Christoph Hellwig wrote:
> blkdev_put must not be called under sb->s_umount to avoid a lock order
> reversal with disk->open_mutex once call backs from block devices to
> the file system using the holder ops are supported. Move the call
> to btrfs_close_devices into btrfs_free_fs_info so that it is closed
> from ->kill_sb (which is also called from the mount failure handling
> path unlike ->put_super) as well as when an fs_info is freed because
> an existing superblock already exists.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
Reply to: