Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
- To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
- Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" <martin.petersen@oracle.com>, Christoph Böhmwalder <christoph.boehmwalder@linbit.com>, Coly Li <colyli@suse.de>
- Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
- From: Jan Höppner <hoeppner@linux.ibm.com>
- Date: Mon, 11 Apr 2022 14:03:50 +0200
- Message-id: <[🔎] e971095e-1015-c348-3c24-114193ee5ff0@linux.ibm.com>
- In-reply-to: <[🔎] 20220409045043.23593-25-hch@lst.de>
- References: <[🔎] 20220409045043.23593-1-hch@lst.de> <[🔎] 20220409045043.23593-25-hch@lst.de>
On 09/04/2022 06:50, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
>
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---
For
> drivers/s390/block/dasd_fba.c | 1 -
Acked-by: Jan Höppner <hoeppner@linux.ibm.com>
Reply to: