[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#995366: marked as done (xfce4-pulseaudio-plugin: repeatedly polls D-Bus names, should watch NameOwnerChanged instead)

Your message dated Thu, 15 Jun 2023 10:33:05 +0000
with message-id <E1q9kHp-00D65a-LF@fasolo.debian.org>
and subject line Bug#995366: fixed in xfce4-pulseaudio-plugin 0.4.7-1
has caused the Debian Bug report #995366,
regarding xfce4-pulseaudio-plugin: repeatedly polls D-Bus names, should watch NameOwnerChanged instead
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
995366: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995366
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xfce4-pulseaudio-plugin
Version: 0.4.3-1
Severity: normal
Tags: upstream

While using debian-live-11.0.0-amd64-xfce.iso to try to reproduce an
unrelated issue, I noticed that the pulseaudio plugin for the panel
calls the ListNames() D-Bus method approximately once per second.
This causes the system to wake up unnecessarily, and is likely to be
a waste of electricity on an otherwise idle system. It also makes it
more difficult to debug the unrelated issue with dbus-monitor :-)

Looking at upstream source code, this seems to be because it calls
pulseaudio_mpris_tick_cb() once per second, which calls
pulseaudio_mpris_get_available_players(), which calls ListNames.

This shouldn't be necessary: D-Bus is designed to be completely idle (no
messages sent, no messages received, no wakeups) if nothing interesting
is happening, similar to other AF_UNIX-based protocols such as X11.

Workaround: remove the Pulseaudio plugin (the volume control) from the
panel while debugging D-Bus-related issues.

I tried to report this upstream, but so far I have been unable to set
up an account on XFCE's Gitlab (presumably the email confirmation has
been greylisted).

For protocols like MPRIS that use an equivalence class of names starting
with a prefix, the intended pattern since dbus-daemon 1.6.0 (stable
release in 2012) is this:

* Add a match rule for the NameOwnerChanged signal with
  arg0namespace="org.mpris.MediaPlayer2"
    - in GDBus, this is something like:
        g_dbus_connection_signal_subscribe (connection,
                                            "org.freedesktop.DBus",
                                            "org.freedesktop.DBus",
                                            "NameOwnerChanged",
                                            "/org/freedesktop/DBus",
                                            "org.mpris.MediaPlayer2",
                                            G_DBUS_SIGNAL_FLAGS_MATCH_ARG0_NAMESPACE,
                                            name_owner_changed_cb, ...);

* When the signal is received, its arguments are the name, the old owner,
  and the new owner
    - if the new owner is "", the name is disappearing from the bus:
      remove it from the list of MPRIS media players
    - otherwise, the name is appearing on the bus: add it to the list of
      MPRIS media players

* After connecting to the signal, call ListNames *once* to populate the
  initial list of MPRIS media players

    smcv

--- End Message ---
--- Begin Message --- 
Source: xfce4-pulseaudio-plugin
Source-Version: 0.4.7-1
Done: Unit 193 <unit193@debian.org>

We believe that the bug you reported is fixed in the latest version of
xfce4-pulseaudio-plugin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995366@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Unit 193 <unit193@debian.org> (supplier of updated xfce4-pulseaudio-plugin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA384

Format: 1.8
Date: Thu, 15 Jun 2023 05:21:29 -0400
Source: xfce4-pulseaudio-plugin
Architecture: source
Version: 0.4.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Xfce Maintainers <debian-xfce@lists.debian.org>
Changed-By: Unit 193 <unit193@debian.org>
Closes: 995366
Changes:
 xfce4-pulseaudio-plugin (0.4.7-1) unstable; urgency=medium
 .
   * New upstream version 0.4.7.
     - Subscribe NameOwnerChanged to watch MPRIS changes instead of timer.
       Closes: #995366
   * d/rules:
     - Use execute_after_auto_install instead of override_dh_auto_install.
   * d/docs, d/rules: Opt-out of trimmed changelogs, install NEWS as changelog.
   * Update Standards-Version to 4.6.2.
Checksums-Sha1:
 0902f937202d9137acd5d93250f3b139125fb477 2383 xfce4-pulseaudio-plugin_0.4.7-1.dsc
 cdce988c61c986bcd65a9b7dcc30ddf39b2e5e49 432495 xfce4-pulseaudio-plugin_0.4.7.orig.tar.bz2
 2f9c00009464be342cb2fd07ac9da7eeb1778f80 3624 xfce4-pulseaudio-plugin_0.4.7-1.debian.tar.xz
 601a7d2bd25d6ba1512bc8f4e83d9352f2b87d59 16348 xfce4-pulseaudio-plugin_0.4.7-1_amd64.buildinfo
Checksums-Sha256:
 b4d8497a31951513644b48719cf6a2417683b380fe1021867858bb1f4dc88465 2383 xfce4-pulseaudio-plugin_0.4.7-1.dsc
 50dd090771441cd7e300e764a1bc48435ace4c3ebaa1bdd8490b4095f3968e2c 432495 xfce4-pulseaudio-plugin_0.4.7.orig.tar.bz2
 19e08c3a7e68d6804b29bab948a736b32611efa7406133e0c9880eeb8b928eee 3624 xfce4-pulseaudio-plugin_0.4.7-1.debian.tar.xz
 8d790a0e90f9bd69e4fd2e6a5190ccb83c0b4c504e33a3da53565ad57d9e5295 16348 xfce4-pulseaudio-plugin_0.4.7-1_amd64.buildinfo
Files:
 6eb51ddbee2448f892a365b7f0ce6acf 2383 xfce optional xfce4-pulseaudio-plugin_0.4.7-1.dsc
 7d1041a7538daf8171dbbc71f5bbefe9 432495 xfce optional xfce4-pulseaudio-plugin_0.4.7.orig.tar.bz2
 e4557f8bc1455cd4afa90e1ec435a449 3624 xfce optional xfce4-pulseaudio-plugin_0.4.7-1.debian.tar.xz
 b61324c57acaace5b362d60abd512320 16348 xfce optional xfce4-pulseaudio-plugin_0.4.7-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCQAdFiEEjbPlhoZdK0orGFpcUAHhsJqjdEsFAmSK2swACgkQUAHhsJqj
dEuKoA//Wr9UYnCYQMTgW2G4LA7GdvhIrdmonMjHRxhCdHcMkOOX1L7RIWpt8x4g
7X16Q0/RY6Bi9pRvBs/F5K8OyQOzQkx8j5of/7wdBAnkp5OZ6PMYViKauUjZ6PVK
XD6y2IsTEtV3s9r9/RQKXrLoLzjDPA0EsRgD33Q0g+JppvX0aRaljjCEXD5AJEa6
Uqc67eD+jIzBL5PJ343lgQxrwSfrxZ+Es96cxZlNZhz0irxQDe3n8ulk3ElB6tAJ
FcEx3kEh64v3EtATH3FAvLE5dVnYEKp0wlyU8BzNHiwhgevfeyds7h3q0CGxSEFS
Hpkmrvdxg4MVb9RBKWeN4cwdDLPmKSpR2qZowewuiZWHMNotAEsXumC1aVWmzHuz
UKy9qUuDReUNL1p+QhllryC+esghVMwqqryEVH6ofFjRZ6obyLbZCKDEK3jUImvh
4QSQxtuOTRSol3r3njTZnC+vNJQ03WY6DSAD4d/87CPRVNpFHRVLIyDoqVfp9wHk
Twm26l0dCMxzA0s9ptTFDUNTOylZ3rTDNAK1GEERS9ySY0BYZTfAlAP1g6esvLfj
u+OvpS+zjwvgkhLPL2bIk7oFIzHX5vsKawGsm4kJJY5nplNGEPAIupQ9bIG/a6tN
yq5+LmUREBVlUeqmmDwMb+PMKvhTFRlKY56LCPnfoPzdJ3d05pc=
=RSY4
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: