Bug#942141: xfce4: Xfce 4.14 XDG_DATA_DIRS="/usr/share:/usr/local/share:/usr/share"

[Сергей Фёдоров <serfyod0vr@yandex.ru>]

Package: xfce4
Version: 4.14
Severity: normal
Tags: patch



-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.utf8, LC_CTYPE=ru_RU.utf8 (charmap=UTF-8), LANGUAGE=ru_RU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages xfce4 depends on:
ii  libxfce4ui-utils         4.14.1-1+b1
ii  thunar                   1.8.9-1+b1
ii  xfce4-appfinder          4.14.0-1+b1
ii  xfce4-panel              4.14.1-1
ii  xfce4-pulseaudio-plugin  0.4.2-1
ii  xfce4-session            4.14.0-1+b1
ii  xfce4-settings           4.14.1-1
ii  xfconf                   4.14.1-1
ii  xfdesktop4               4.14.1-1
ii  xfwm4                    4.14.0-2

Versions of packages xfce4 recommends:
ii  desktop-base      10.0.3
ii  tango-icon-theme  0.8.90-7
ii  thunar-volman     0.9.5-1+b1
ii  xfce4-notifyd     0.4.4-1+b1
ii  xorg              1:7.7+19

Versions of packages xfce4 suggests:
pn  xfce4-goodies        <none>
ii  xfce4-power-manager  1.6.5-2

-- no debconf information

In the terminal window, in the output of the "env" command, I found the line:
   XDG_DATA_DIRS=/usr/share/xfce4:/usr/local/share/:/usr/share/:/usr/share/

It made me think.
In "/usr/bin/startxfce4" in the block

   if test "x$XDG_DATA_DIRS" = "x"
   then
     if test "x/usr/share" = "x/usr/local/share" -o "x/usr/share" = "x/usr/share"; then
       XDG_DATA_DIRS="/usr/local/share:/usr/share"
     else
       XDG_DATA_DIRS="/usr/share:/usr/local/share:/usr/share"
     fi
   else
     XDG_DATA_DIRS="$XDG_DATA_DIRS:/usr/share"
   fi

excluded duplication for XDG_DATA_DIRS - line
   XDG_DATA_DIRS="/usr/share:/usr/local/share:/usr/share"
replaced by
   XDG_DATA_DIRS="/usr/share:/usr/local/share"

This did not solve the problem.
Commenting a line:
   XDG_DATA_DIRS="$XDG_DATA_DIRS:/usr/share"
after “else”, the “Login” window reappears to enter Debian and there is no way out of this cycle.

Installing Debian 10.1 on another blank disk from scratch will repeat the situation:
   Duplicate rows in the Select Application window

Transferring “*.desktop” files from “/usr/share/applications/” to “/usr/local/share/applications/”
solves the situation, but the question remains why, if there are “* .desktop” files in
“/usr/share/applications/" duplication of lines occurs only for these files.
But in the “Thunar 1.8.9” file manager, line duplication does not occur with “Open with”.

Replacing the line finally solved the problem:
   else
      XDG_DATA_DIRS="$XDG_DATA_DIRS:/usr/share"
on
   else
      XDG_DATA_DIRS="$ XDG_DATA_DIRS"

Now when executing the “env” command, I find the line:
   XDG_DATA_DIRS=/usr/share/xfce4:/usr/local/share/:/usr/share/

Problem Duplication of lines in the "Application Selection" window was resolved,
lines no longer duplicated under Doublecmd.

Changed normal code block in "/usr/bin/startxfce4" is:

   if test "x$XDG_DATA_DIRS" = "x"
   then
     if test "x/usr/share" = "x/usr/local/share" -o "x/usr/share" = "x/usr/share"; then
       XDG_DATA_DIRS="/usr/local/share:/usr/share"
     else
       XDG_DATA_DIRS="/usr/share:/usr/local/share"
     fi
   else
     XDG_DATA_DIRS="$XDG_DATA_DIRS"
   fi