Bug#888705: abseil-cpp packaging
On Wed, May 20, 2020 at 5:56 PM Benjamin Barenblat <bbaren@debian.org> wrote:
> On Tuesday, May 19, 2020, at 8:59 PM +0200, László Böszörményi (GCS) wrote:
> > Doesn't build with GCC 10 due to symbol changes.
>
> Good point. Is there an established way to deal with this? Or should I
> just upload this as-is to unstable and then upload a GCC-10-compatible
> version to experimental?
You don't have to - but please be prepared that when GCC 10 will be
the default in Sid, Abseil will FTBFS.
> On Wednesday, May 20, 2020, at 12:03 PM +0200, László Böszörményi (GCS) wrote:
> > Please do build static libraries with the following patch.
>
> This is great – thanks! I’m still unfamiliar with CMake; I really
> appreciate you figuring out the incantations to get it to build both.
>
> As written, this patch builds shared libraries first and then archives,
> which causes abslTargets.cmake to prefer archives over shared objects
> when linking against Abseil. I’d like to modify it to go in the other
> order, thus preferring shared libraries over archives. Requiring an
> explicit opt-in before using Abseil archives would make it more
> difficult to accidentally violate the One Definition Rule by
> accidentally double-linking an Abseil archive. Furthermore, it would
> create less work for packagers trying to use the shared Abseil
> libraries, which I expect will be the usual case inside Debian. Does
> that sound reasonable?
Yup, please do so. Thanks go to you for packaging it and hopefully
uploaded soon.
Laszlo/GCS
Reply to: