Quoting Kartik Kulkarni (2019-07-19 21:32:36) > Package: wnpp > Severity: wishlist > Owner: Kartik Kulkarni <kartik.koolks@gmail.com> > > * Package name : node-solid-rest > Version : 1.0.7 > Upstream Author : Jeff Zucker <dubzed@gmail.com> > * URL : https://github.com/jeff-zucker/solid-rest.git > * License : (MIT/X) > Programming Lang: javascript > Description : client-side multi-backend API for Solid requests > > Solid (Social Linked Data) is a web decentralization project > with the aims to radically change > the way web applications work > by developing a platform for linked-data applications > that are completely decentralized > and fully under users' control > rather than controlled by other entities. > . > This package contains Solid REST usable with Nodejs > > This package is a dependecy for solid-server and needs to be packaged > for the packaging of solid-server. > . > I have been in contact with a Debian Developer who will sponsor the > package I've taken a look at https://salsa.debian.org/js-team/node-solid-rest - generally looks good, but I'd prefer that you tidy some minor warts before initial release of the package: Git should track only authored code - currently contains some generated files as well: Please run "debian/rules clean" and remove cleaned files from git. Please add DEP-3 header to the debian/patches/*.patch files - see e.g. source package node-solid-jose for an example. See also https://dep-team.pages.debian.net/deps/dep3/ Package follows DEP-14 git branch naming (set in debian/gbp.conf) with debian/master as main branch but then also has a master branch. Please consistently uses debian/master and delete master branch. See also https://dep-team.pages.debian.net/deps/dep14/ File debian/clean lists seemingly superfluous cleanup - how do those .debian/* files ever get created?!? Maybe it is sensible and I am simply missing some details on how the build works (and would then be happy if you could help point out to me why those lines are needed), but if those lines is not really needed then please remove them. And while at it, than file has an unneeded empty line at the end. Also, please use descriptive commit messages (a commit message of "modified for build" is not helpful in understanding why those lines were added). Currently only a server-side Node.js binary package is provided. That's fine, but please add a debian/TODO file documenting that browser-targeted binary is deliberately omitted and why, so that someone looking for that get a clue on whether relevant to bug us about that or perhaps even help us solve it. Also, source package should probably not build-depend on webpack for now either. Seems the pandoc-generated README.* files doesn't get installed into the binary package. See e.g. source package node-solid-jose, build target override_dh_installdocs in debian rules. While at it, file sold-rest.png seems to also need to be installed (as it is linked from the pandoc-generated README.html). - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
Attachment:
signature.asc
Description: signature