[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888985: [pkg-go] Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)





On Sat, Feb 10, 2018 at 6:08 PM, Pete Heist <pete@eventide.io> wrote:

On Feb 9, 2018, at 11:43 AM, Pete Heist <pete@eventide.io> wrote:

On Feb 9, 2018, at 8:15 AM, Michael Stapelberg <stapelberg@debian.org> wrote:

On Fri, Feb 9, 2018 at 2:09 AM, Pete Heist <pete@eventide.io> wrote:

From the original warnings you sent I know I’ve fixed all except "I: irtt source: testsuite-autopkgtest-missing”, but a) I’m not seeing that warning and b) I’m seeing two others. So my questions are:

1) What are your expectations for 'testsuite-autopkgtest-missing', and why am I not seeing it? There are no unit tests to run.

Did you apply the ~/.lintianrc I provided? Not doing so would explain the difference. autopkgtest is helpful even if it only compiles the package in question. Why are there no unit tests for your code? :)

2) Do you care about 'debian-watch-does-not-check-gpg-signature' and 'no-upstream-changelog’? I do not sign the upstream, and the changes are in README.md, in case those should be split out...

They’re not important for the time being. Of course, if you could start signing upstream and provide a separate changelog file, that would be great.

Thanks!

Ok, I’ve updated the irtt package:

- I added a couple high-value unit tests, which also satisfies lintian.

- CHANGES.md is split out from README.md to satisfy 'no-upstream-changelog'.

Great, thanks for both of these! :)
 

- I tried getting signatures working but punted because GitHub creates a .tar.gz, which I signed with a .tar.gz.asc, but the build process expects a .tar.xz.asc in the upstream, so lintian then warns with 'orig-tarball-missing-upstream-signature'. Is there any pkg-go example of signatures working with a GitHub hosted repo? Otherwise I’ll eventually figure it out.

The process currently is a bit clunky. dh-make-golang hardcodes using xz (via tar J), so either you change that in dh-make-golang’s source, or you manually create the packaging git repository:

# save GitHub .tar.gz as irtt_0.9.0.orig.tar.gz
% mkdir irtt
% cd irtt
% git init
% gbp import-orig ../irtt_0.9.0.orig.tar.gz
% cp -r /tmp/dh-make-golang/irtt/debian .
% git commit -a -m "Initial packaging"
 

- I blew away the irtt.git repo and started over so I could just stay on the rails of your dh-make-golang.html blog entry, hope that’s fine.

Sure.
 

Let me know if anything else. Thanks!

It would be good to avoid copying the systemd .service file into debian/. I think you can instead install it with a debian/rules override. See e.g. https://sources.debian.org/src/forked-daapd/25.0-2/debian/rules/?hl=22#L22

Aside from that, the package looks very clean now.

Let me know how you’d like to proceed regarding the signatures. It’s not a requirement to sign the releases for now, but note that after the initial upload, we don’t have the luxury of starting with a fresh repository anymore.
 

Pete




--
Best regards,
Michael

Reply to: