[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#686447: Review of debian/copyright for zfs-linux



Hi Darik,

On 09.08.2014 00:09, Darik Horn wrote:
On Fri, Aug 8, 2014 at 6:05 AM, Turbo Fredriksson <turbo@bayour.com> wrote:

This have already been accepted (I saw a 0.6.3 update being accepted into the
archive a couple of days ago).

How were the licensing and namespace concerns resolved?  After two
years of waiting, it would be nice to know the decision criteria for
such important management issues.

I think he was talking about SPL [1], not zfs-linux here.

As far as I know nothing has been resolved with respect to zfs-linux, yet.

On Fri, Aug 8, 2014 at 7:58 AM, Andreas Cadhalpun
<andreas.cadhalpun@googlemail.com> wrote:

This problem can be circumvented easily, by not listing every file with
different copyright as separate stanza, but instead aggregation all
copyright holders for files licensed under CDDL-1.0 into the first, general
stanza (which also would make debian/copyright a lot easier to
review/maintain, e.g. avoids duplicated stanzas etc.).

When I did this code audit, in part to satisfy Debian import
requirements, the debian/copyright file was intentionally broken out
like this to avoid ambiguity and ensure copyright pedigree.

This is important because the downstream Debian sources are often
disjoint or unmergeable from the upstream git repository -- as you
just noticed -- and because there was an upstream conversion from svn
to git that mangled some of the commit history.

OK, it's fine to have them separated, but in that case shouldn't the copyright of the default stanza match what the COPYRIGHT file says, or maybe just add Sun Microsystems, Inc. to the default stanza?

I have CCed the copyright holders of these man pages, to inform them that they have to license them under a DFSG-free license, or they won't be allowed into Debian main.

Why are you making this request?  Surely this is the responsibility of
the package maintainers to do this work and maintain an upstream
rapport.

I'm just trying to help here. Of course, it would have been better if the package maintainers had noticed this, but as it seems that a potentially not DFSG-free file made it into the Debian archive, it's now an issue that affects any Debian user.

As you are the author of the man page in question here, do you agree to license the file man/man1/splat.1 under a DFSG-free license, e.g. GPL-2+?

We haven't seen Aron Xu or Carlos Alberto Lopez Perez at the upstream
issue tracker or support lists in more than a year.  Conversely, Turbo
Fredriksson is active and should therefore be added to the primary
list of people with Debian FTP upload privileges.

I didn't know that. They are currently listed as the only uploaders of SPL, but as that package is team-maintained by the Debian ZFS on Linux maintainers, which Turbo is part of, I don't see a problem.

I haven't reviewed the debian/copyright of zfs-linux fully yet, but attached patch fixes some issues I already noticed:
 * changing Disclaimer: to Comment: as the first one is only meant for
   explanations, why a packages has to be in non-free
 * removing some stanzas for files not present in the repository
 * removing duplicated stanzas
 * converting the Source: field of 'Files: debian/*' to a comment, as
   the Source: field is only allowed in the header
 * adding the missing licenses for some files
 * adding the choice-of-venue of the CDDL to debian/copyright

Best regards,
Andreas


1: https://tracker.debian.org/pkg/spl-linux
diff --git a/debian/copyright b/debian/copyright
index e45253b..f1c656c 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -2,7 +2,7 @@ Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: Native ZFS for Linux
 Upstream-Contact: Brian Behlendorf <behlendorf1@llnl.gov>
 Source: https://github.com/zfsonlinux/zfs/
-Disclaimer:
+Comment:
  This work was produced at the Lawrence Livermore National Laboratory
  (LLNL) under Contract No. DE-AC52-07NA27344 (Contract 44) between
  the U.S. Department of Energy (DOE) and Lawrence Livermore National
@@ -60,11 +60,6 @@ Copyright: Oracle
  Delphix
 License: CDDL-1.0
 
-Files: cmd/zfs/zfs_main.h
-Copyright: Oracle
- Nexenta Systems, Inc.
-License: CDDL-1.0
-
 Files: cmd/zfs/zfs_util.?
 Copyright: Oracle
 License: CDDL-1.0
@@ -116,37 +111,23 @@ Files: cmd/zvol_id/*
 Copyright: Fajar A. Nugraha.
 License: CDDL-1.0
 
-Files: config/config.guess
-Copyright: Free Software Foundation, Inc.
-License: GPL-2+
-
-Files: config/config.sub
-Copyright: Free Software Foundation, Inc.
-License: GPL-2+
-
-Files: config/depcomp
-Copyright: Free Software Foundation, Inc.
-License: GPL-2+
-
-Files: config/ltmain.sh
-Copyright: Free Software Foundation, Inc.
-License: GPL-2+
-
-Files: config/missing
-Copyright: Free Software Foundation, Inc.
-License: GPL-2+
-
 Files: debian/*
 Copyright: Darik Horn <dajhorn@vanadac.com>
-Source: https://github.com/dajhorn/pkg-spl/
 License: GPL-2+
+Comment:
+ On Debian systems, the full text of the GNU General Public License
+ version 2 can be found in the file `/usr/share/common-licenses/GPL-2'.
+ .
+ The source for the debian packaging can be found at:
+ https://github.com/zfsonlinux/pkg-zfs/
+
+Files: debian/tree/zfsutils/etc/bash_completion.d/zfs
+Copyright: 2013, Aneurin Price <aneurin.price@gmail.com>
+License: Expat
 
 Files: etc/init.d/zfs.gentoo.in
 Copyright: Gentoo Foundation
 License: BSD-2-clause
- Copyright (c) 2011, Gentoo Foundation
- All rights reserved.
- .
  Redistribution and use in source and binary forms, with or without
  modification, are permitted provided that the following conditions are met:
  .
@@ -199,14 +180,6 @@ Files: include/sys/arc.h
 Copyright: Oracle
 License: CDDL-1.0
 
-Files: include/avl.h
-Copyright: Sun Microsystems, Inc.
-License: CDDL-1.0
-
-Files: include/avl_impl.h
-Copyright: Sun Microsystems, Inc.
-License: CDDL-1.0
-
 Files: include/sys/bplist.h
 Copyright: Oracle
 License: CDDL-1.0
@@ -317,10 +290,6 @@ Files: include/sys/rrwlock.h
 Copyright: Sun Microsystems, Inc.
 License: CDDL-1.0
 
-Files: include/sys/refcount.h
-Copyright: Oracle
-License: CDDL-1.0
-
 Files: include/sys/sa.h
 Copyright: Oracle
 License: CDDL-1.0
@@ -360,7 +329,7 @@ License: CDDL-1.0
 Files: include/sys/u8_textprep_data.h
 Copyright: Unicode, Inc.
  Sun Microsystems, Inc.
-License:
+License: Expat~Unicode
  Permission is hereby granted, free of charge, to any person obtaining
  a copy of the Unicode data files and any associated documentation (the
  "Data Files") or Unicode software and any associated documentation (the
@@ -416,14 +385,6 @@ Files: include/sys/unique.h
 Copyright: Sun Microsystems, Inc.
 License: CDDL-1.0
 
-Files: include/sys/unique.h
-Copyright: Sun Microsystems, Inc.
- Hewlett-Packard Company
- Open Software Foundation, Inc.
- Digital Equipment Corporation.
- Microsoft
-License: CDDL-1.0
-
 Files: include/sys/vdev_file.h
 Copyright: Sun Microsystems, Inc.
 License: CDDL-1.0
@@ -443,10 +404,6 @@ Copyright: AT&T
  The Regents of the University of California
 License: CDDL-1.0
 
-Files: include/sys/vdev_impl.h
-Copyright: Oracle
-License: CDDL-1.0
-
 Files: include/sys/zap.h
 Copyright: Oracle
 License: CDDL-1.0
@@ -1040,6 +997,32 @@ Files: module/zfs/lzjb.c
 Copyright: Oracle
 License: CDDL-1.0
 
+Files: module/zfs/lz4.c
+Copyright: 2011-2013, Yann Collet
+License: BSD-2-Clause
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions are
+ met:
+ .
+ * Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above
+   copyright notice, this list of conditions and the following disclaimer
+   in the documentation and/or other materials provided with the
+   distribution.
+ .
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
 Files: module/zfs/metaslab.c
 Copyright: Oracle
  Delphix
@@ -1274,6 +1257,13 @@ Copyright: Cluster File Systems, Inc.
  Lawrence Livermore National Security, LLC.
 License: GPL-2+
 
+Files: scripts/kmodtool
+Copyright:
+ 2003-2012, Ville Skyttä <ville.skytta@iki.fi>,
+ 2003-2012, Thorsten Leemhuis <fedora@leemhuis.info>
+ 2003-2012, Nicolas Chauvet <kwizart@gmail.com>
+License: Expat
+
 License: GPL-2+
  This program is free software; you can redistribute it and/or modify it under
  the terms of the GNU General Public License as published by the Free Software
@@ -1604,3 +1594,17 @@ License: CDDL-1.0
  of rights under this License and You agree to work with Initial Developer and
  Contributors to distribute such responsibility on an equitable basis. Nothing
  herein is intended or shall be deemed to constitute any admission of liability.
+ .
+ --------------------------------------------------------------------
+ .
+ NOTICE PURSUANT TO SECTION 9 OF THE COMMON DEVELOPMENT AND
+ DISTRIBUTION LICENSE (CDDL)
+ .
+ For Covered Software in this distribution, this License shall
+ be governed by the laws of the State of California (excluding
+ conflict-of-law provisions).
+ .
+ Any litigation relating to this License shall be subject to the
+ jurisdiction of the Federal Courts of the Northern District of
+ California and the state courts of the State of California, with
+ venue lying in Santa Clara County, California.

Reply to: