[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for sponsoring update of plotdrop




On Mon, Jun 27, 2016 at 12:41 AM, Philipp Huebner <debalance@debian.org> wrote:
Hi,

Am 26.06.2016 um 21:05 schrieb James Clarke:
> Hi Jordan,
>> On 25 Jun 2016, at 21:21, Jordan Mantha <jordan.mantha@gmail.com>
>> wrote:
>>
>> I'm looking for a sponsor for an upload of plotdrop. I am the
>> upstream maintainer (and former DM) and finally got to fixing all
>> the Sourceforge, Debian, and Launchpad bugs. Since the package is
>> maintained in the debian-science git repo I took the liberty of
>> pushing the new upstream and updated the packaging (last touched in
>> 2009). It's been a few years since I did any packaging but I think
>> it should be in pretty good shape and I used pbuilder to build and
>> test it.
>>
>> You can find the git repo at:
>> https://anonscm.debian.org/git/debian-science/packages/plotdrop.git
>
>>
> I’m not a DD and thus cannot sponsor an upload, but here are my
> thoughts from having a quick look:
>
> 1. Your d/rules is fairly simple; you should switch to the dh(1)
> sequencer
>
> 2. You should enable as much hardening as you can[1]; if you do 1.,
> you get some of this for free, but unless you have a good reason to
> you should add “hardening=+all” to DEB_BUILD_MAINT_OPTIONS
>
> 3. Your Vcs-Git should be
> https://anonscm.debian.org/git/debian-science/packages/plotdrop.git
> (note the .git and lack of a trailing /), as given at the bottom of
> the cgit summary page
>
> Regards, James
>
> [1] https://wiki.debian.org/HardeningWalkthrough
>

I'm happy to sponsor your upload, but in addition to James' suggestions
you should also update debian/copyright.

And a debian/gbp.conf specifying the git-debian-branch would be nice :)


Regards,
--
 .''`.   Philipp Huebner <debalance@debian.org>
: :'  :  pgp fp: 6719 25C5 B8CD E74A 5225  3DF9 E5CA 8C49 25E4 205F
`. `'`
  `-


Thanks  to both of you for the assistance. I think I've taken care of all of James' suggestions (thanks for those, it did simplify my debian/rules).

I couldn't figure out how to make my simple upstream Makefile accept added CFLAGS/LDFLAGS from debian/rules so I've patched it to work for now. As upstream I will work on making a better behaved Makefile but I don't want to make a new upstream release just for that.

I added the debian/gbp.conf file. That git repo was created before all the branch names were standardized.

With regard to debian/copyright, I thought I had gotten that mostly fixed. What problem do you see with it? I confess it's been quite a while since I did any Debian packaging so I on doubt am missing something obvious.


BTW, I'm uncertain about what debian/changelog should look like for working with a git repo and sponsorship. Should I keep it unreleased ("gbp dch --snapshot" ?)and let the sponsoring DD do the final "gbp dch --release"

-- Jordan

Reply to: