[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-flores 0.0.8





On 25/7/23 5:31 AM, thegodtune wrote:
Hi,

I just packaged ruby-flores 0.0.8, a build dependency for arr-pm
0.0.12, which is a build dependency for gitlab 15.11.6

Kindly check the package out at
https://salsa.debian.org/thegodtune/ruby-flores

Please review and sponsor. Thank you!

1. Please use pristine-tar branch and push
2. Please have separate commits for each logical change
3. Your override_dh_auto_install is unnecessary and currently no ruby files are included in the final deb file

For disabling a specific test, you can use patch like

--- a/spec/flores/pki_integration_spec.rb
+++ b/spec/flores/pki_integration_spec.rb
@@ -56,7 +56,7 @@
       end
     end

-    it "should successfully connect as a client" do
+    xit "should successfully connect as a client" do
       socket = TCPSocket.new(server_address, server_port)
       ssl_client = OpenSSL::SSL::SSLSocket.new(socket, client_context)
       ssl_client.connect


Reply to: