[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS:- ruby-sassc



Thank you, for the comment and the changes suggested, 
I have done the changes and it would be great if someone can look and review it and sponsor the package 
Thank you 
Manas Kashyap


On Wed, Jul 10, 2019 at 3:52 AM Cédric Boutillier <boutil@debian.org> wrote:
Hi Manas,

On Mon, Jul 08, 2019 at 11:17:11PM +0530, Manas Kashyap wrote:
> Hi,

> The following packages are ready to be uploaded
> Could you please sponsor them?

> ruby-sassc to unstable https://salsa.debian.org/ruby-team/ruby-sassc
> The package was tested on both gbp and sbuild. They're also lintian-clean.

Thanks for your work. The package looks fine. I have just two comments:
- the Architecture field in debian/control should be all instead of any
  as there is no architecture dependent file
- the short and long descriptions could be improved sensibly. You could
  explain briefly explain what Sass is and what the package is trying to
  do. The long description should maybe start with "This package"
  instead of "It" and should not make reference to "you".
  You could have a look at recommendation from the deleveloper's
  reference for good practices, chap. 6.2.1-3
  https://www.debian.org/doc/manuals/developers-reference/ch06.en.html#bpp-desc-basics

Cheers,

Cédric

Reply to: