[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983544: marked as done (unblock: kodi/19.0+dfsg1-1)

Your message dated Sun, 28 Feb 2021 22:25:32 +0100
with message-id <c855da28-af54-be00-eeb6-937cd87c3a5e@debian.org>
and subject line Re: Bug#983544: unblock: kodi/19.0+dfsg1-1
has caused the Debian Bug report #983544,
regarding unblock: kodi/19.0+dfsg1-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
983544: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983544
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: mattia@debian.org, balint@balintreczey.hu

Dear colleagues,

Please unblock package kodi within bullseye.

[ Reason ]
The block reason is the delayed upload of Kodi package having 'kodi-addons-dev'
(the development headers package used to build Kodi addons but not targeting end-users)
split to arch-independent part ('kodi-addons-dev-common') and the architecture-dependent
part ('kodi-addons-dev').

This change was prepared on Salsa on January 8th 2021
(see https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/d1dc691507e7c28a3818fa338d68646cd0a5ae83)
to keep files from '/usr/share' in arch:all package (making multi-arch hinter happy),
but also to prevent buildds from building Kodi addons on architectures there is no Kodi for (like mipsel).

Overall, the change in question:

  * Restored the proper way for buildds to know if it is feasible to build Kodi addons
    for a given architecture, reducing build resource waste,

  * Made the package multi-arch compliant.

[ Impact ]

If the unblock is not granted, end users will receive release candidate 1 of Kodi 19.0
instead of final release. The difference between the build in bullseye and final release
is 65 bug fixes, including several PVR and JSON-RPC API corrections that have great usability
impact.

The risks of reverting the commit in question are discussed under "Risks" paragraph.

[ Tests ]

The following tests were performed on the Debian uploads:

  * Autotest suite (590 tests) passes during package build,
  * Autopkgtest passes as well,
  * All the kodi addons build fine with this package split (it needs to
    be noted that the questioned change is relevant only to this one use
    case),
  * Manual daily-driver testing by ~25 users who I invited to test
    Kodi from Debian in various channels (my unofficial Github
    nightly repo, Kodi forums, Kodinupstream bugtracker, Discord
    groups etc)

The 19.0 final upload is tested in its current shape and builds fine on
all release architectures, except of mipsel / mips64el (due to #969946)

[ Risks ]

Reverting previous iteration of multiarch fix in hope to get Kodi 19.0 in unstable faster
has already led to an FTBFS requiring two more uploads.
See the following git commits for more background on the history of the
change:
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/0f31a067216559064cf885ba389c18b87e50085b
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/d1dc691507e7c28a3818fa338d68646cd0a5ae83
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/1fc69926ae708e5a426bee9be85aaacb3a141407
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/621b27d14fbd971eca88861a4bb2393eff90d3f6
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/2ffa9c994e4c939ce2ece997aea0c4ac4015e4e6
https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/commit/80d363c229b0361e5778894ecbe88904818f1c34

Keeping in mind that any regression during the freeze can end dropping Kodi irrevocably
off bullseye, I would prefer not to break the tested package layout.

[ Checklist ]

  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing (including one with
      only the debian/ part, for easier reviewing)

[ Other info ]

Please don't let the results of 8mo+ work on Kodi packaging for Debian to get dropped
off Debian :)

Also note that this change was really read in time by the proper
deadline (i.e. 12th February), but wasn't uploaded to unstable just
because we missed the extra bit of the freeze policy that also changes
to the set of binary packages wasn't allowed, plus my sponsor wanted to
save an extra upload of kodi just to have this small change migrate when
it could have easily do it together with the expected 19.0 upload (which
was entirely planned to be within the scope of the soft freeze, and
still is).

unblock kodi/19.0+dfsg1-1

--- End Message ---
--- Begin Message --- 
Hi,

On 26-02-2021 00:00, Vasyl Gello wrote:
> unblock kodi/19.0+dfsg1-1

I've removed my block.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: