Bug#794194: britney: Strip off Multi-Arch qualifiers in reverse dependency calculation

[Niels Thykier <niels@thykier.net>]

Control: tags -1 moreinfo

Martin Pitt:
> Control: tag -1 confirmed -moreinfo
> 
> Hello Niels,
> 
> Niels Thykier [2016-01-16 14:34 +0000]:
>> Does this issue still apply to Britney at the current master branch?  We
>> have removed register_reverses in favour of a different approach for
>> unrelated reasons.
> 
> Yes, it does still apply. I rebased Ubuntu's britney onto current
> master, and the test_multiarch_dep() test fails. So I reopened the
> bug.
> 

Ok thanks. :)

> Current britney uses  apt_pkg.parse_depends() which already has an
> option to strip off multi-arch qualifiers. It just needs to be
> enabled.
> 
> Patch attached.
> 
> Thanks,
> 
> Martin
> 
> [1] https://git.launchpad.net/~ubuntu-release/+git/britney2-ubuntu/tree/tests/test_autopkgtest.py#n1233
> 
> 

We need to handle the multi-arch dependencies explicitly as "pkg:amd64"
is *not* acceptable for an i386 packages (etc.).  Unfortunately, the
proposed patch causes exactly that behaviour[1]. :-/

[1] We have a very crude test for this in
https://anonscm.debian.org/cgit/collab-maint/britney2-tests.git/tree/t/multi-arch-depends/

It probably only covers the most straight forward case.