[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700251: pu: package libproc-processtable-perl/0.45-1+squeeze1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: pu

Hi

I prepared a patch for libproc-processtable-perl (the same as for the
upload to unstable) to fix #650500: CVE-2011-4363, to fix unsafe use
of temporary file. There is no DSA for this.

 https://security-tracker.debian.org/tracker/CVE-2011-4363
 
The debdiff contains a debian/gbp.conf (if needed I can remove it).
This was added to ease the work in the pkg-perl git repos on that
branch.

Do the changes look ok for an upload via stable-proposed-updates for
stable? The fix did not yet migrate to testing (I had just uploaded
the fix to unstable). So it would be same ok to wait for that before
proceeding.

Regards,
Salvatore
diff -u libproc-processtable-perl-0.45/debian/changelog libproc-processtable-perl-0.45/debian/changelog
--- libproc-processtable-perl-0.45/debian/changelog
+++ libproc-processtable-perl-0.45/debian/changelog
@@ -1,3 +1,10 @@
+libproc-processtable-perl (0.45-1+squeeze1) stable; urgency=low
+
+  * Team upload.
+  * [SECURITY] CVE-2011-4363: Fix unsafe temporary file usage (Closes: #650500)
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Sun, 10 Feb 2013 16:16:41 +0100
+
 libproc-processtable-perl (0.45-1) unstable; urgency=low
 
   * New upstream release.
only in patch2:
unchanged:
--- libproc-processtable-perl-0.45.orig/ProcessTable.pm
+++ libproc-processtable-perl-0.45/ProcessTable.pm
@@ -4,6 +4,7 @@
 
 use strict;
 use Carp;
+use Fcntl;
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK $AUTOLOAD);
 
 require Exporter;
@@ -109,7 +110,11 @@
         $self->_get_tty_list;
         my $old_umask = umask;
         umask 022;
-        Storable::store(\%Proc::ProcessTable::TTYDEVS, $TTYDEVSFILE);
+
+        sysopen( my $ttydevs_fh, $TTYDEVSFILE, O_WRONLY | O_EXCL | O_CREAT )
+            or die "$TTYDEVSFILE was created by other process";
+        Storable::store_fd( \%Proc::ProcessTable::TTYDEVS, $ttydevs_fh );
+        close $ttydevs_fh;
         umask $old_umask;
       }
     }
only in patch2:
unchanged:
--- libproc-processtable-perl-0.45.orig/debian/gbp.conf
+++ libproc-processtable-perl-0.45/debian/gbp.conf
@@ -0,0 +1,2 @@
+[DEFAULT]
+debian-branch = squeeze

Reply to: