[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#955465: qtcreator: Unnecessary botan build dep



Package: qtcreator
Version: 4.11.0-2
Severity: normal
Tags: patch

Dear Maintainer,

qtcreator has a now unnecessary build dependency on package
'libbotan-2-dev'.

Botan is no longer used since upstream commit
d7178b88c4b2572fb83b28f8178940766216deed
("SSH: Use OpenSSH tools").

Therefore, I suggest do drop that build dependency, in particular
since qtcreator is currently marked for autoremoval due to bug
#952951 ("botan: Replace PKCS11 headers provided by OASIS").

A patch to do so will be attached.

Kind regards,
Michael

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages qtcreator depends on:
ii  libc6                                  2.30-2
ii  libclang1-8                            1:8.0.1-9
ii  libgcc-s1 [libgcc1]                    10-20200324-1
ii  libgcc1                                1:10-20200324-1
ii  libkf5syntaxhighlighting5              5.62.0-3
ii  libllvm8                               1:8.0.1-9
ii  libqbscore1.13                         1.13.1-2
ii  libqt5concurrent5                      5.12.5+dfsg-9
ii  libqt5core5a [qtbase-abi-5-12-5]       5.12.5+dfsg-9
ii  libqt5designer5                        5.12.5-2+b2
ii  libqt5designercomponents5              5.12.5-2+b2
ii  libqt5gui5                             5.12.5+dfsg-9
ii  libqt5help5                            5.12.5-2+b2
ii  libqt5network5                         5.12.5+dfsg-9
ii  libqt5printsupport5                    5.12.5+dfsg-9
ii  libqt5qml5 [qtdeclarative-abi-5-12-5]  5.12.5-5
ii  libqt5quick5                           5.12.5-5
ii  libqt5quickwidgets5                    5.12.5-5
ii  libqt5script5                          5.12.5+dfsg-2
ii  libqt5serialport5                      5.12.5-1
ii  libqt5sql5                             5.12.5+dfsg-9
ii  libqt5sql5-sqlite                      5.12.5+dfsg-9
ii  libqt5widgets5                         5.12.5+dfsg-9
ii  libqt5xml5                             5.12.5+dfsg-9
ii  libstdc++6                             10-20200324-1
ii  qml-module-qtqml-models2               5.12.5-5
ii  qml-module-qtquick-controls            5.12.5-1+b1
ii  qml-module-qtquick2                    5.12.5-5
ii  qtchooser                              66-2
ii  qtcreator-data                         4.11.0-2

Versions of packages qtcreator recommends:
ii  clang                          1:9.0-49.1
ii  clang-tidy                     1:9.0-49.1
ii  gdb                            9.1-2
ii  konsole [x-terminal-emulator]  4:19.08.1-2+b1
ii  make                           4.2.1-1.2
ii  qmlscene                       5.12.5-5
ii  qt5-doc                        5.12.5-1
ii  qt5-qmltooling-plugins         5.12.5-5
ii  qtbase5-dev-tools              5.12.5+dfsg-9
ii  qtcreator-doc                  4.11.0-2
ii  qtdeclarative5-dev-tools       5.12.5-5
ii  qttools5-dev-tools             5.12.5-2+b2
ii  qttranslations5-l10n           5.12.5-1
ii  qtxmlpatterns5-dev-tools       5.12.5-1
ii  xterm [x-terminal-emulator]    353-1

Versions of packages qtcreator suggests:
ii  clazy       1.6-2+b1
ii  cmake       3.16.3-1
ii  g++         4:9.2.1-3.1
ii  git         1:2.25.1-1
pn  kate-data   <none>
ii  subversion  1.13.0-2+b1
ii  valgrind    1:3.15.0-1

-- no debconf information
From 2c75d9fd06b44e8e381a39af2e81fc38f4e01c37 Mon Sep 17 00:00:00 2001
From: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue, 31 Mar 2020 17:06:28 +0200
Subject: [PATCH] Drop unused botan build dependency

Botan has been removed upstream with

    commit d7178b88c4b2572fb83b28f8178940766216deed
    Author: Christian Kandeler <christian.kandeler@qt.io>
    Date:   Fri Nov 23 11:07:57 2018 +0100

        SSH: Use OpenSSH tools

        ... instead of our own SSH library.

        Advantages:
            - Full compatibility with OpenSSH behavior guaranteed.
            - Minimal maintenance effort.
            - Less code to build.
            - Big chunk of 3rd party sources can be removed from our repository.

        One the downside, Windows users now need to install OpenSSH for
        RemoteLinux support. Hoewever, people doing embedded development
        probably have it installed anyway.

        [ChangeLog] Switched SSH backend to OpenSSH

        Fixes: QTCREATORBUG-15744
        Fixes: QTCREATORBUG-15807
        Fixes: QTCREATORBUG-19306
        Fixes: QTCREATORBUG-20210
        Change-Id: Ifcfefdd39401e45ba1f4aca35d2c5bf7046c7aab
        Reviewed-by: Eike Ziller <eike.ziller@qt.io>
        Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
---
 debian/control | 1 -
 debian/rules   | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index 0b279a0..9529edb 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,6 @@ Uploaders: Adam Majer <adamm@zombino.com>,
            Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>,
            Simon Quigley <tsimonq2@debian.org>
 Build-Depends: debhelper-compat (= 12),
-               libbotan-2-dev,
                libclang-8-dev,
                libicu-dev,
                libjs-jquery,
diff --git a/debian/rules b/debian/rules
index 477a768..afa3771 100755
--- a/debian/rules
+++ b/debian/rules
@@ -18,10 +18,9 @@ override_dh_auto_configure:
 	dh_auto_configure --buildsystem=qmake -- \
 		-recursive \
 		QBS_INSTALL_DIR=/usr \
-		USE_SYSTEM_BOTAN=1 \
 		LLVM_INSTALL_DIR="$(LLVM_INSTALL_DIR)" \
 		KSYNTAXHIGHLIGHTING_LIB_DIR="/usr/lib/$(DEB_HOST_MULTIARCH)/" \
-		CONFIG+="disable_external_rpath use_system_botan" \
+		CONFIG+="disable_external_rpath" \
 		$(CURDIR) IDE_LIBRARY_BASENAME=lib/$(DEB_HOST_MULTIARCH) IDE_PACKAGE_MODE=1 $(extra_configure_opts)
 
 override_dh_auto_install:
-- 
2.25.1


Reply to: