[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#905378: marked as done (mplength: incorrectly handles missing lengths)

Your message dated Thu, 14 Nov 2019 22:04:51 +0000
with message-id <E1iVNER-000GGt-Kp@fasolo.debian.org>
and subject line Bug#905378: fixed in mpdtoys 0.25.0
has caused the Debian Bug report #905378,
regarding mplength: incorrectly handles missing lengths
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
905378: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905378
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: mpdtoys
Version: 0.25
Severity: minor
Tags: patch upstream

Some items in a playlist, such as Internet streams, may not have an
associated time. mplength will then complain with:

    Use of uninitialized value in addition (+) at ./mplength line 41,
    <GEN0> line 6021.

Checking first if times are defined fixes this.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.UTF-8), LANGUAGE=en_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages mpdtoys depends on:
ii  libaudio-mpd-perl  2.004-2
ii  perl               5.26.2-6

mpdtoys recommends no packages.

Versions of packages mpdtoys suggests:
ii  libproc-daemon-perl    0.23-1
pn  libstring-approx-perl  <none>
ii  libterm-readkey-perl   2.37-1+b2
ii  mpd                    0.20.19-1+b3

-- no debconf information

-- 
|)|/  Ryan Kavanagh      | GPG: 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac     |      BD95 8F7B F8FC 4A11 C97A
--- Begin Message --- 
Some items in a playlist, such as Internet streams, may not have an
associated time. mplength will then complain with:

    Use of uninitialized value in addition (+) at ./mplength line 41,
    <GEN0> line 6021.

Checking first if times are defined fixes this.
---
 mplength | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mplength b/mplength
index 621891b..1c0f157 100755
--- a/mplength
+++ b/mplength
@@ -38,7 +38,9 @@ my $pl=$mpd->playlist;
 my @list=$pl->as_items;
 my $secs=0;
 foreach my $item (@list) {
-	$secs+=$item->time;
+	if (defined $item->time) {
+		$secs+=$item->time;
+	}
 }
 my $mins=int($secs/60);
 printf "%i:%02i\n", $mins, ($secs-$mins*60);
-- 
2.18.0

--- End Message ---

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: mpdtoys
Source-Version: 0.25.0

We believe that the bug you reported is fixed in the latest version of
mpdtoys, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 905378@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated mpdtoys package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 14 Nov 2019 16:39:04 -0500
Source: mpdtoys
Architecture: source
Version: 0.25.0
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 905378
Changes:
 mpdtoys (0.25.0) unstable; urgency=medium
 .
   * QA upload.
   * debian/source/format: Explicitly use "3.0 (native)" format.
   * debian/copyright: Refresh information.
   * debian/control:
     + Bump Standards-Version to 4.4.1.
     + Bump debhelper compat to v12.
     + Update Vcs-* fields to use git packaging repo under Salsa
       Debian group.
   * mplength: Check whether variable is defined first.
     (Closes: #905378)
Checksums-Sha1:
 ba0aa1421cf59485be824738a6c964c1e6f64343 1560 mpdtoys_0.25.0.dsc
 ec72a6becc7efd8573257ce0283c7675fca1b8c7 13236 mpdtoys_0.25.0.tar.xz
 01cd60d34eb8d5de987de1de71130333a5f84031 5475 mpdtoys_0.25.0_amd64.buildinfo
Checksums-Sha256:
 9a29f551390a35ee54680b2695f38813ecc6478c1238369bfc3dbf6ebd8c481b 1560 mpdtoys_0.25.0.dsc
 c68dfef547ffad67cbf1b64f3a73e5f861822deb9e4715850aac9ddf7dc502ce 13236 mpdtoys_0.25.0.tar.xz
 38baa25d3a226eab307463577afe104c7e7bc9e16ece8ca0034c228399d1358d 5475 mpdtoys_0.25.0_amd64.buildinfo
Files:
 7a5cccc1f49b4100f09edd19f8e4813f 1560 sound optional mpdtoys_0.25.0.dsc
 119a1cbee6a1b475114cc9098587b629 13236 sound optional mpdtoys_0.25.0.tar.xz
 744e2c237ba1de52abb87dac1b82e0a5 5475 sound optional mpdtoys_0.25.0_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAl3NyscACgkQwpPntGGC
Ws7EOxAAwJw06ppRi+6FiuoMV4fOh/uU2tQMR8tNuui9BB0VfucR0xkDsabNlLOD
OafoulhBamlus9HaF85QHAbgGZ+Zf6XSguwLtrcziquPifYGfQsEixosO/1gNrb9
hpgYn0Nr1tGjyojk5ghvxq/FqtnPFddWWL++jhvhoQLiBQjK7Ej3oUNMhsLFHlPu
QViC5vmQyFZtxa5/7WRLaoHe83Md9VugsFvcFrxk6gRBjlaQGpfWjcVAHYfNwnu1
prDV/6xqsu79Q1e/2Er6LaOijkSokSHexgT/VbL7sZthY56uqOWX9uQZwNUbQpgm
F0KKbC3xJkPp53zBpTtQNhs2TRPAAfvtVfzwfG3VmB8/i+zRcIMqvNvm81wIiPPe
p339upyORVKTg6ZjphsBQze/uGAEGtnkMQM+aSS4JGCurs0yJUzdGCzQ4Tt7apgV
Tm++Nebv0SPW5WKNrxk+stlRGdVuLP7h88SA2W/hEQGYhm1JX2I/gJOEbgpuX8Qw
QYxSh7bnRfrha3wiI6Z3NZyEBao18fWa7qWtWowmc+qsLIVR69OSAFo8rfqH2kvp
u3DOELBdjDC28oui3qJQvtjvSOqtYETMvLf4Y+7jhj+mYrH8BeK+2+yjuBlAfOdz
DM/azgKoZGtVSLI08A+LvH4nuO7unrWqa/baM7DCd52G4T55+Pc=
=2l2t
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: