Bug#922653: irqbalance: restart loop when running under runit and with a single CPU
Package: irqbalance
Version: 1.5.0-3
Severity: normal
Tags: patch
Hi,
While testing something else in a virtual machine I noticed that
irqbalance exits if it detects a single CPU. When running under runit
the service is continuously restarted.
I would suggest detecting this case directly from the run script and
stopping the service with sv, something like this:
------------------------------------------------------------
#!/bin/sh
if test $(nproc) = 1; then
echo "Not starting irqbalance: only one CPU detected"
sv stop .
exit 0
fi
exec /usr/sbin/irqbalance --foreground
------------------------------------------------------------
Cheers,
Mat.
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.19.0-1-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)
Versions of packages irqbalance depends on:
ii debconf [debconf-2.0] 1.5.70
ii libc6 2.28-6
ii libcap-ng0 0.7.9-2
ii libglib2.0-0 2.58.3-1
ii libncursesw6 6.1+20181013-1
ii libnuma1 2.0.12-1
ii libsystemd0 240-5
ii libtinfo6 6.1+20181013-1
ii lsb-base 10.2018112800
ii runit-helper 2.8.4
irqbalance recommends no packages.
irqbalance suggests no packages.
-- debconf information:
irqbalance/oneshot: false
irqbalance/enable: true
Reply to: