Bug#917631: opendkim: /lib/systemd/system/opendkim.services fails to read /etc/default/opendkim configuration

[Petri Koistinen <petri.koistinen@iki.fi>]

Package: opendkim
Version: 2.11.0~alpha-10+deb9u1
Severity: wishlist
Justification: Policy 9.3.2

Dear Maintainer,

I tried to follow instructions on https://wiki.debian.org/opendkim page.

I refers putting data into /etc/default/opendkim about socket like:
SOCKET="inet:8891@localhost"

However it seems that file /lib/systemd/system/opendkim.service ignore
defaults in /etc/default/opendkim file:

root@hel ~ # cat /lib/systemd/system/opendkim.service 
[Unit]
Description=OpenDKIM DomainKeys Identified Mail (DKIM) Milter
Documentation=man:opendkim(8) man:opendkim.conf(5)
man:opendkim-genkey(8) man:opendkim-genzone(8) man:opendkim-testadsp(8)
man:opendkim-testkey http://www.opendkim.org/docs.html
After=network.target nss-lookup.target 

[Service]
Type=forking
PIDFile=/var/run/opendkim/opendkim.pid
UMask=0007
ExecStart=/usr/sbin/opendkim -x /etc/opendkim.conf
Restart=on-failure
ExecReload=/bin/kill -USR1 $MAINPID

[Install]
WantedBy=multi-user.target
root@hel ~ # 

I can do workarount and add sokcet to /etc/opendkim.conf like this:
root@hel ~ # cat /etc/opendkim.conf 
logwhy yes
syslog yes
umask 007
mode sv
keytable /etc/postfix/dkim/keytable
signingtable file:/etc/postfix/dkim/signingtable
pidfile /var/run/opendkim/opendkim.pid
oversignheaders From
trustanchorfile /usr/share/dns/root.key
userid opendkim
socket inet:8891@localhost
root@hel ~ # 

If I comment that last comment line with "socket inet:8891@localhost"
restart opendkim will fail even there is socket definition in default
file:

root@hel ~ # cat /etc/default/opendkim 
RUNDIR=/var/run/opendkim
USER=opendkim
GROUP=opendkim
PIDFILE=$RUNDIR/$NAME.pid
SOCKET=inet:8891@localhost
root@hel ~ # 

And you can find in /var/log/daemon.log clear indication of failure:

Dec 29 15:12:29 hel opendkim[32459]: opendkim: milter socket must be specified

OK, I find this bug report duplicate of #861169 maybe I document here
just the annoying trouble of trying to figure out how fix problem.

Apparenty there commands fix the problem.

# /lib/opendkim/opendkim.service.generate
# systemctl daemon-reload
# service opendkim restart

I wish this all would just work little bit easier.

-- System Information:
Debian Release: 9.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages opendkim depends on:
ii  adduser              3.115
ii  dns-root-data        2017072601~deb9u1
ii  init-system-helpers  1.48
ii  libbsd0              0.8.3-1
ii  libc6                2.24-11+deb9u3
ii  libdb5.3             5.3.28-12+deb9u1
ii  libldap-2.4-2        2.4.44+dfsg-5+deb9u2
ii  liblua5.1-0          5.1.5-8.1+b2
ii  libmemcached11       1.0.18-4.1
ii  libmemcachedutil2    1.0.18-4.1
ii  libmilter1.0.1       8.15.2-8
ii  libopendbx1          1.4.6-11+b1
ii  libopendkim11        2.11.0~alpha-10+deb9u1
ii  librbl1              2.11.0~alpha-10+deb9u1
ii  libssl1.1            1.1.0j-1~deb9u1
ii  libunbound2          1.6.0-3+deb9u2
ii  libvbr2              2.11.0~alpha-10+deb9u1
ii  lsb-base             9.20161125

opendkim recommends no packages.

Versions of packages opendkim suggests:
ii  opendkim-tools  2.11.0~alpha-10+deb9u1
pn  unbound         <none>

-- Configuration Files:
/etc/default/opendkim changed [not included]
/etc/opendkim.conf changed [not included]

-- no debconf information