Bug#904049: marked as done (cricket: Please consider using getent instead of sg in maintscript)
Your message dated Wed, 18 Jul 2018 21:51:31 +0000
with message-id <E1ffuM7-00077Y-4v@fasolo.debian.org>
and subject line Bug#904049: fixed in cricket 1.0.5-22
has caused the Debian Bug report #904049,
regarding cricket: Please consider using getent instead of sg in maintscript
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
904049: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904049
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: cricket
Version: 1.0.5-21
Severity: wishlist
User: andreas@fatal.se
Usertags: sg-maintscript-removal
Hello,
Your package cricket was one of the few matches for 'sg' usage in
maintainer scripts[1]. As a preparation for potentially solving #833256
in the future, I'd like to ask you to change your package to adhere to
what seems to be the established defacto standard in maintainer-script
code for adding users/groups these days, eg.
if ! getent passwd | grep ^joeuser: > /dev/null; then
adduser ...
fi
... and similar for groups with 'getent group'.
More examples can be found at
https://codesearch.debian.net/search?q=path%3A.*postinst+adduser
or for a specific example see:
https://sources.debian.org/src/util-linux/2.32-0.1/debian/uuid-runtime.postinst/
Please note that adding (and removing) system users and groups are still
not described in Debian Policy (see #228692), but this will eliminate
the need for the 'sg' utility and be more in line with what other
packages are doing.
If your package are removing users or groups during purge, you might
want to consider that there seems to be consensus against ever doing so
(see mailing list thread linked from #228692).
If time permits and I haven't heard anything back I'll consider fixing
this via a NMU while at DebCamp/DebConf.
Regards,
Andreas Henriksson
[1]: https://codesearch.debian.net/search?q=path%3Adebian%2F.*p%28ost%7Cre%29%28inst%7Crm%29+%5C+sg%5C+
--- End Message ---
--- Begin Message ---
Source: cricket
Source-Version: 1.0.5-22
We believe that the bug you reported is fixed in the latest version of
cricket, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 904049@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Henriksson <andreas@fatal.se> (supplier of updated cricket package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 18 Jul 2018 23:21:38 +0200
Source: cricket
Binary: cricket
Architecture: source
Version: 1.0.5-22
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Henriksson <andreas@fatal.se>
Description:
cricket - Program for collection and display of time-series data
Closes: 904049
Changes:
cricket (1.0.5-22) unstable; urgency=medium
.
* QA upload.
* Replace id/sg usage in postrm with getent (as already used in postinst)
Closes: #904049
- please note that removing users/groups (as done both in postinst
and postrm) is discuraged! (See mailing list thread linked from
#228692 for discusson.)
Checksums-Sha1:
016d9362148fdeb26b1dbbadd25a58c25363ef5c 1687 cricket_1.0.5-22.dsc
bc2cb9de2c0aab30f339f7a5c4265d6d53d3cace 21700 cricket_1.0.5-22.debian.tar.xz
1379343314c648b0b6edcf7beb9c9d8fd714f2e0 5886 cricket_1.0.5-22_amd64.buildinfo
Checksums-Sha256:
429cb1c39ded7225e1950fd5ea2ee6abb8687b83551c6c9ce4a33e1a8d040c4f 1687 cricket_1.0.5-22.dsc
44804c33a5016387ac4ab4873352efb83c9d6dc506b410419c920445d3028d17 21700 cricket_1.0.5-22.debian.tar.xz
fdb0adf538c6bc0158ea2bae9da1be76eebc09f5e41d9ddc711f5f91d4d54608 5886 cricket_1.0.5-22_amd64.buildinfo
Files:
243681d1c2684f0f4f4b94fda26e0ee9 1687 net extra cricket_1.0.5-22.dsc
79fceba5e8acf2bebc6996f3796a1503 21700 net extra cricket_1.0.5-22.debian.tar.xz
79a41c7f1bb88a684dbe11a46a6009d6 5886 net extra cricket_1.0.5-22_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE+uHltkZSvnmOJ4zCC8R9xk0TUwYFAltPsV4RHGFuZHJlYXNA
ZmF0YWwuc2UACgkQC8R9xk0TUwaoWw/+JB4AH5ckzwwhskrT0FDlYD4MCdFrN7GB
afr2XBIBfuVwVvihPzrKAtojUNeZPVBcIvw/rUcziBfcORXuEwCt7RG7wmZcOHtr
v4j9rriVTL+mDNH46Ibk3KKOhkn/eXNtXp5j/IzuPRHBha+tquVJcFCor/wVWxoP
6QknqPYwRJg2ZP4X0nCvuNyNxc8VTF3zXuRdZ64thq6ybs6f98UI/ki5qf6NgT5F
HEXk1mGeHJYjKZbjL8dBbUtYI8qULW1eDJqi8mjqu7tsaeaDZswiCOa6c7rrFN9o
B9eIsA+CbVGq2G8W8bcI6zAe7l55KKHv42PgD7MGnSRtu+CrrGo5wFrt5bGXQE3y
iSzJ242EFlUoglKTqfllgA2uGkfE87qY7ZuB+lnBK4BIgEM5ZtU/APGNG3tGqgVQ
SrI5Xr1BD0bIH4E4YT3g7sqtHEBTgiUrkMSfYvCUugdY70GfFlVnBdaB9jyPiAB5
kDZaz7oKTmSRNToucPqOa9Ed3EaKw7jFHrwGrJmQAQnEjZPGjxXRY2yZzmH5gAD6
qqCphSSe1+HH2N8RG1zz7nOrzIpdFZhECbDO0dBcxt0j0L2gHw+nUQaHB/qhMGko
URBrOWgqF+VyJSna/7N/tf00bR9r3kTuaGNJsLdBIr8AUPiia+xmDdPOLn9ASZwC
/t9/bbF0pm0=
=Vm7E
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: