Bug#1024367: In 4.9.1, the example uses not recommended install -s

[Enrico Zini <enrico@debian.org>]

Package: debian-policy
Version: 4.6.1.1
Severity: normal

Hello, and thank you for maintaining the Policy!

Policy paragraph 4.9.1 has an example debian/rules which contains these
lines:

   INSTALL_PROGRAM = $(INSTALL) -p    -o root -g root  -m  755

   ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
       INSTALL_PROGRAM += -s
   endif

However, paragraph 10.1 recommends against it:

   It is not recommended to strip binaries by passing the "-s" flag to
   "install", because this fails to remove .comment and .note sections,
   and also prevents the automatic creation of dbgsym binary packages by
   tools like "dh_strip".

I would personally prefer if the example built on debhelper. If the
intention is to show what are the expectations at a lower level then
I wish the example had a comment saying "This snippet serves to explain
what are the expectations as a lower level. You usually want to use
debhelper instead"

Enrico


-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-2-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), LANGUAGE=en_IE:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

debian-policy depends on no packages.

Versions of packages debian-policy recommends:
ii  libjs-sphinxdoc  4.5.0-4

Versions of packages debian-policy suggests:
ii  doc-base  0.11.1

-- no debconf information