[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1041211: libsdl-perl: FTBFS and autopkgtest failure with sdl12-compat, especially on 32-bit



On Tue, Jul 18, 2023 at 06:24:32PM +0100, Simon McVittie wrote:

> SDL upstream have clarified that what libsdl-perl is doing here was
> never correct, so actually, this is more a libsdl-perl bug than a
> sdl12-compat bug. The result of SDL_SetVideoMode() is never meant to be
> freed by a library user, only internally by SDL itself.
> 
> I've sent a possible fix to https://github.com/PerlGameDev/SDL/pull/306,
> but I'm intentionally not tagging this bug +patch, because it badly needs
> reviewing by someone who has written XS bindings before (I'd never tried
> writing XS before today).

Hi, many thanks for your work on this.

I fear my expertise is not up to reviewing this properly, and SDL-Perl
upstream seems to be very quiet nowadays.

I'm copying the debian-perl list for some visibility, maybe somebody
there could have a look?

If not, I think I'd be OK just pushing your patch to sid and seeing
how it fares. It would be unfortunate to lose frozen-bubble from the
next release...
-- 
Niko Tyni   ntyni@debian.org


Reply to: