[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fully debhelper-based build infrastructure



* Mike Miller <mtmiller@debian.org> [2018-01-12 14:07]:

What do you think about having a clean function (as you have it now) versus a dh_octave_clean helper? Is it better to have fine grained explicit helper scripts or only when the steps become complex?

I have no strong opinion on this. For now, the action of the clean function in Buildsystem/octave.pm are pretty simple, so let us keep it like that.

Is it acceptable to have the sequence plugin conditionally insert dh_octave_check based on the "nocheck" option?

Sure, this is a good idea, thanks for the suggestion. It is implemented in this commit: https://salsa.debian.org/pkg-octave-team/dh-octave/commit/bf4435ddf78321f3a982fa0bad6873e6c0208473

Rafael


Reply to: