Re: Bug#129650: ocaml: error byte-compiling :-(

[Sven <luther@dpt-info.u-strasbg.fr>]

On Fri, Jan 18, 2002 at 08:53:30AM -0800, Ian Zimmerman wrote:
> 
> itz> I get this while installing ocaml 3.04-4:
> itz> 
> itz> While compiling caml-eval-buffer in file /usr/share/emacs/20.7/site-lisp/ocaml/caml.el:
> itz> ** malformed let binding: (setq error (caml-eval-phrase 500 (point-min) (if arg (point-max) here)))
> itz> ** Attempt to let-bind nonvariable (error)
> itz> 
> itz> not your fault of course.
> 
> Sven> Please send me the patch and i will check and apply it.
> 
> Here's the patch:
> 
> *** caml.el.orig	Fri Jan 18 08:45:20 2002
> --- caml.el	Fri Jan 18 08:47:50 2002
> ***************
> *** 507,517 ****
>   With prefix arg, evaluate past the whole buffer, no stopping at
>   the current point."
>     (interactive "p")
> !   (let ((here (point)) ((error))
>       (goto-char (point-min))
> !     (setq error
> !           (caml-eval-phrase 500 (point-min) (if arg (point-max) here))))
> !     (if error (set-mark (error)))
>       (goto-char here)))
>   
>   (defun caml-show-subshell ()
> --- 507,517 ----
>   With prefix arg, evaluate past the whole buffer, no stopping at
>   the current point."
>     (interactive "p")
> !   (let ((here (point)) (errpt))
>       (goto-char (point-min))
> !     (setq errpt
> !           (caml-eval-phrase 500 (point-min) (if arg (point-max) here)))
> !     (if errpt (set-mark errpt))
>       (goto-char here)))
>   
>   (defun caml-show-subshell ()

What is the reason for renaming error to errpt ? Would the removing of the
last ) not have been enough ?

Friendly,

Sven Luther