[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066642: pd-pdogg: FTBFS: oggwrite~.c:156:25: error: implicit declaration of function ‘error’; did you mean ‘herror’? [-Werror=implicit-function-declaration]



Source: pd-pdogg
Version: 0.25.1-8
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -DPD -I "/usr/include/pd"  -DUNIX -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC  -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -o oggwrite~.pd_linux.o -c oggwrite~.c
> oggwrite~.c: In function ‘oggwrite_write’:
> oggwrite~.c:156:25: error: implicit declaration of function ‘error’; did you mean ‘herror’? [-Werror=implicit-function-declaration]
>   156 |                         error("oggwrite~: could not send ogg header to server (%d)", err);
>       |                         ^~~~~
>       |                         herror
> oggamp~.c: In function ‘oggamp_vorbis_init’:
> oggamp~.c:252:17: error: implicit declaration of function ‘error’; did you mean ‘herror’? [-Werror=implicit-function-declaration]
>   252 |                 error("oggamp~: input does not appear to be an ogg bitstream (error %d)", result);
>       |                 ^~~~~
>       |                 herror
> oggwrite~.c: In function ‘oggwrite_comment’:
> oggwrite~.c:555:17: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   555 |         comment = atom_gensym(argv)->s_name;
>       |                 ^
> oggamp~.c: In function ‘oggamp_child_main’:
> oggamp~.c:826:41: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   826 |                 sprintf(boo, "fifosize %d\n",
>       |                                        ~^
>       |                                         |
>       |                                         int
>       |                                        %ld
>   827 |                 x->x_fifosize);
>       |                 ~~~~~~~~~~~~~            
>       |                  |
>       |                  t_int {aka long int}
> oggamp~.c:843:53: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   843 |                                 sprintf(boo, "head %d, tail %d\n", x->x_fifohead, x->x_fifotail);
>       |                                                    ~^              ~~~~~~~~~~~~~
>       |                                                     |               |
>       |                                                     int             t_int {aka long int}
>       |                                                    %ld
> oggamp~.c:843:62: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   843 |                                 sprintf(boo, "head %d, tail %d\n", x->x_fifohead, x->x_fifotail);
>       |                                                             ~^                    ~~~~~~~~~~~~~
>       |                                                              |                     |
>       |                                                              int                   t_int {aka long int}
>       |                                                             %ld
> oggamp~.c:883:52: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   883 |                         sprintf(boo, "after: head %d, tail %d\n",
>       |                                                   ~^
>       |                                                    |
>       |                                                    int
>       |                                                   %ld
>   884 |                                 x->x_fifohead, x->x_fifotail);
>       |                                 ~~~~~~~~~~~~~       
>       |                                  |
>       |                                  t_int {aka long int}
> oggamp~.c:883:61: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   883 |                         sprintf(boo, "after: head %d, tail %d\n",
>       |                                                            ~^
>       |                                                             |
>       |                                                             int
>       |                                                            %ld
>   884 |                                 x->x_fifohead, x->x_fifotail);
>       |                                                ~~~~~~~~~~~~~ 
>       |                                                 |
>       |                                                 t_int {aka long int}
> oggamp~.c: In function ‘oggamp_perform’:
> oggamp~.c:1090:50: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>  1090 |                         pd_error(x, "dsp: error %d", x->x_connecterror);
>       |                                                 ~^   ~~~~~~~~~~~~~~~~~
>       |                                                  |    |
>       |                                                  int  t_int {aka long int}
>       |                                                 %ld
> oggamp~.c: In function ‘oggamp_connect’:
> oggamp~.c:1190:31: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1190 |                 x->x_hostname = hostsym->s_name;
>       |                               ^
> oggamp~.c:1191:33: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1191 |                 x->x_mountpoint = mountsym->s_name;
>       |                                 ^
> oggamp~.c: In function ‘oggamp_connect_url’:
> oggamp~.c:1224:11: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1224 |         p = url->s_name;
>       |           ^
> oggcast~.c: In function ‘oggcast_stream’:
> oggcast~.c:289:25: error: implicit declaration of function ‘error’; did you mean ‘herror’? [-Werror=implicit-function-declaration]
>   289 |                         error("oggcast~: could not send ogg header to server (%d)", err);
>       |                         ^~~~~
>       |                         herror
> oggcast~.c: In function ‘oggcast_child_connect’:
> oggcast~.c:602:36: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   602 |                 if(sprintf(resp, "%d", br_nom) == -1)    /* convert int to a string */
>       |                                   ~^   ~~~~~~
>       |                                    |   |
>       |                                    int t_int {aka long int}
>       |                                   %ld
> oggcast~.c:670:36: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   670 |                 if(sprintf(resp, "%d", br_nom) == -1)    /* convert int to a string */
>       |                                   ~^   ~~~~~~
>       |                                    |   |
>       |                                    int t_int {aka long int}
>       |                                   %ld
> oggcast~.c: In function ‘oggcast_child_main’:
> oggcast~.c:845:49: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   845 |                         sprintf(boo, "fifosize %d\n", x->x_fifosize);
>       |                                                ~^     ~~~~~~~~~~~~~
>       |                                                 |      |
>       |                                                 int    t_int {aka long int}
>       |                                                %ld
> oggcast~.c:891:52: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   891 |                         sprintf(boo, "after: head %d, tail %d, pages %d\n", x->x_fifohead, x->x_fifotail, sysrtn);
>       |                                                   ~^                        ~~~~~~~~~~~~~
>       |                                                    |                         |
>       |                                                    int                       t_int {aka long int}
>       |                                                   %ld
> oggcast~.c:891:61: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
>   891 |                         sprintf(boo, "after: head %d, tail %d, pages %d\n", x->x_fifohead, x->x_fifotail, sysrtn);
>       |                                                            ~^                              ~~~~~~~~~~~~~
>       |                                                             |                               |
>       |                                                             int                             t_int {aka long int}
>       |                                                            %ld
> oggcast~.c: In function ‘oggcast_connect’:
> oggcast~.c:1183:31: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1183 |                 x->x_hostname = hostsym->s_name;
>       |                               ^
> oggcast~.c:1184:33: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1184 |                 x->x_mountpoint = mountsym->s_name;
>       |                                 ^
> oggcast~.c: In function ‘oggcast_password’:
> oggcast~.c:1245:17: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1245 |     x->x_passwd = password->s_name;
>       |                 ^
> ++++ info: linking objects in oggread~.pd_linux for lib pdogg
> cc -rdynamic -shared -fPIC -Wl,-rpath,"\$ORIGIN",--enable-new-dtags  -Wl,-z,relro -Wl,-z,now  -o oggread~.pd_linux oggread~.pd_linux.o  -lc -lm -lvorbis -lvorbisenc -lvorbisfile   
> cc1: some warnings being treated as errors
> make[1]: *** [/usr/share/pd-lib-builder//Makefile.pdlibbuilder:987: oggwrite~.pd_linux.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pd-pdogg_0.25.1-8_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.


Reply to: