[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1058837: midisport-firmware: use udev.pc to place udev rules



Source: midisport-firmware
Version: 1.2-5
Severity: normal
Tags: patch
User: helmutg@debian.org
Usertags: dep17m2

Dear Maintainer,

your package installs files related to udev, into /lib. These
files need to be moved to /usr/lib as part of Debian's usr-merge
effort [1].

Attached you will find a patch using udev.pc to place the udev files
(using pkg-config). This works today in unstable and also for
bookworm, and is safe to do now.
Once udev.pc in unstable points to /usr/lib, your package will
benefit automatically after a binNMU or any other upload.

If during the trixie cycle your package will undergo structural
changes or any other file moves, please see the wiki and upload
to experimental first when these changes are done.

Later during the trixie cycle I expect this bug class to raise in
priority.

Thank you for considering,
Chris

[1] https://wiki.debian.org/UsrMerge
diff -Nru midisport-firmware-1.2/debian/changelog midisport-firmware-1.2/debian/changelog
--- midisport-firmware-1.2/debian/changelog	2023-09-28 22:48:50.000000000 +0200
+++ midisport-firmware-1.2/debian/changelog	2023-12-17 00:01:52.000000000 +0100
@@ -1,3 +1,10 @@
+midisport-firmware (1.2-5.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use udev.pc to place udev files. (Closes: #-1)
+
+ -- Chris Hofstaedtler <zeha@debian.org>  Sun, 17 Dec 2023 00:01:52 +0100
+
 midisport-firmware (1.2-5) unstable; urgency=medium
 
   * Team upload
diff -Nru midisport-firmware-1.2/debian/control midisport-firmware-1.2/debian/control
--- midisport-firmware-1.2/debian/control	2023-09-28 22:48:50.000000000 +0200
+++ midisport-firmware-1.2/debian/control	2023-12-17 00:01:02.000000000 +0100
@@ -10,7 +10,9 @@
  udev,
  autoconf,
  automake,
- fxload
+ fxload,
+ pkgconf,
+ systemd-dev
 Standards-Version: 3.9.1
 DM-Upload-Allowed: yes
 Homepage: http://usb-midi-fw.sourceforge.net/
diff -Nru midisport-firmware-1.2/debian/control.in midisport-firmware-1.2/debian/control.in
--- midisport-firmware-1.2/debian/control.in	2023-09-28 22:48:50.000000000 +0200
+++ midisport-firmware-1.2/debian/control.in	2023-12-17 00:01:32.000000000 +0100
@@ -7,7 +7,9 @@
  udev,
  autoconf,
  automake,
- fxload
+ fxload,
+ pkgconf,
+ systemd-dev
 Standards-Version: 3.9.1
 DM-Upload-Allowed: yes
 Homepage: http://usb-midi-fw.sourceforge.net/
diff -Nru midisport-firmware-1.2/debian/rules midisport-firmware-1.2/debian/rules
--- midisport-firmware-1.2/debian/rules	2023-09-28 22:48:19.000000000 +0200
+++ midisport-firmware-1.2/debian/rules	2023-12-17 00:01:48.000000000 +0100
@@ -5,7 +5,7 @@
 include /usr/share/cdbs/1/class/makefile.mk
 include /usr/share/cdbs/1/rules/utils.mk
 
-DEB_CONFIGURE_EXTRA_FLAGS := --with-udev=/lib/udev/
+DEB_CONFIGURE_EXTRA_FLAGS := --with-udev=$(shell pkg-config --variable=udevdir udev)/
 
 post-patches::
 	autoreconf -fi

Reply to: