[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024714: Doesn't run tests as part of of the build nor autopkgtest



Package: liblc3
Version: 1.0.1-1
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch

Since pipewire builds with liblc3 now we are working on getting it promoted to Ubuntu main. One of the requirements for Ubuntu to support packages in the main archive is to provide build time tests and autopkgtests. Upstream provides tests which I've enabled in Ubuntu with success, I'm attaching the patch since that should also benefit Debian.

Note that the armhf build on Ubuntu failed on missing Python.h but Build-Depends on libpython3.10-dev feels wrong and shouldn't be needed?


diff -Nru liblc3-1.0.1/debian/changelog liblc3-1.0.1/debian/changelog
--- liblc3-1.0.1/debian/changelog	2022-10-10 22:59:57.000000000 +0200
+++ liblc3-1.0.1/debian/changelog	2022-11-23 16:03:01.000000000 +0100
@@ -1,3 +1,11 @@
+liblc3 (1.0.1-2) UNRELEASED; urgency=medium
+
+  * debian/control, debian/rules, debian/tests/control:
+    - enable the upstream tests during the build and also set them as an
+      autopkgtest
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Wed, 23 Nov 2022 16:03:01 +0100
+
 liblc3 (1.0.1-1) unstable; urgency=medium
 
   * Initial release (Closes: #1021532)
diff -Nru liblc3-1.0.1/debian/control liblc3-1.0.1/debian/control
--- liblc3-1.0.1/debian/control	2022-10-10 22:59:57.000000000 +0200
+++ liblc3-1.0.1/debian/control	2022-11-23 16:03:01.000000000 +0100
@@ -4,7 +4,9 @@
 Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
 Uploaders: Dylan Aïssi <daissi@debian.org>
 Build-Depends: debhelper-compat (= 13),
-               meson
+               meson,
+               python3-numpy,
+               python3-scipy,
 Standards-Version: 4.6.1
 Rules-Requires-Root: no
 Vcs-Browser: https://salsa.debian.org/multimedia-team/liblc3
diff -Nru liblc3-1.0.1/debian/rules liblc3-1.0.1/debian/rules
--- liblc3-1.0.1/debian/rules	2022-10-10 22:59:57.000000000 +0200
+++ liblc3-1.0.1/debian/rules	2022-11-23 15:33:53.000000000 +0100
@@ -8,3 +8,6 @@
 override_dh_auto_configure:
 	dh_auto_configure -- \
 		-Dtools=true
+		
+override_dh_auto_test:
+	V= make test
diff -Nru liblc3-1.0.1/debian/tests/control liblc3-1.0.1/debian/tests/control
--- liblc3-1.0.1/debian/tests/control	1970-01-01 01:00:00.000000000 +0100
+++ liblc3-1.0.1/debian/tests/control	2022-11-23 15:45:22.000000000 +0100
@@ -0,0 +1,3 @@
+Test-Command: dh_auto_configure; dh_auto_build; dh_auto_test
+Depends: @builddeps@
+Restrictions: allow-stderr

Reply to: