--- Begin Message ---
Package: libcamera
Version: 0~git20211108+1b30992b623e-4
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch
Dear Maintainer,
libcamera currently fails to build from source on the ppc64el architecture.
The latest snapshot (i.e., git20211108+1b30992b623e) contains long
double expressions that GCC fails to determine at compile time on
ppc64el. These expressions were not present in the previous snapshot.
Tweaking the "guilty" expressions was enough to make the package build.
This was the recommended solution on RHEL in a similar issue for a
different package:
https://bugzilla.redhat.com/show_bug.cgi?id=1538817#c6
Another option is to build with the -mlong-double-64 flag.
In Ubuntu, the attached patch was applied to achieve the following:
* Fix FTBFS on ppc64el with GCC (LP: #1992331)
Thanks for considering the patch.
-- System Information:
Debian Release: bookworm/sid
APT prefers jammy-updates
APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.15.0-48-generic (SMP w/8 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru libcamera-0~git20211108+1b30992b623e/debian/patches/ppc64el-fix-ftbfs-gcc.patch libcamera-0~git20211108+1b30992b623e/debian/patches/ppc64el-fix-ftbfs-gcc.patch
--- libcamera-0~git20211108+1b30992b623e/debian/patches/ppc64el-fix-ftbfs-gcc.patch 1970-01-01 01:00:00.000000000 +0100
+++ libcamera-0~git20211108+1b30992b623e/debian/patches/ppc64el-fix-ftbfs-gcc.patch 2022-10-10 10:23:29.000000000 +0200
@@ -0,0 +1,34 @@
+Description: fix expressions not considered constant on ppc64el with GCC
+ On ppc64el, GCC seems to be unable to determine the result of some long double
+ expressions at compile time. This makes libcamera fail to build from source on
+ ppc64el.
+ Make sure we only use constexpr on expressions that are considered constant on
+ all architectures.
+Author: Olivier Gayot <olivier.gayot@canonical.com>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libcamera/+bug/1992331
+Forwarded: no
+Last-Update: 2022-10-10
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: libcamera-0~git20211108+1b30992b623e/src/ipa/raspberrypi/raspberrypi.cpp
+===================================================================
+--- libcamera-0~git20211108+1b30992b623e.orig/src/ipa/raspberrypi/raspberrypi.cpp 2022-10-10 08:24:22.091329072 +0000
++++ libcamera-0~git20211108+1b30992b623e/src/ipa/raspberrypi/raspberrypi.cpp 2022-10-10 08:45:31.686454143 +0000
+@@ -61,7 +61,7 @@
+ /* Configure the sensor with these values initially. */
+ constexpr double defaultAnalogueGain = 1.0;
+ constexpr Duration defaultExposureTime = 20.0ms;
+-constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
++constexpr Duration defaultMinFrameDuration = 1s / 30.0;
+ constexpr Duration defaultMaxFrameDuration = 250.0s;
+
+ /*
+@@ -70,7 +70,7 @@
+ * we rate-limit the controller Prepare() and Process() calls to lower than or
+ * equal to this rate.
+ */
+-constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;
++constexpr Duration controllerMinFrameDuration = 1s / 60.0;
+
+ LOG_DEFINE_CATEGORY(IPARPI)
+
diff -Nru libcamera-0~git20211108+1b30992b623e/debian/patches/series libcamera-0~git20211108+1b30992b623e/debian/patches/series
--- libcamera-0~git20211108+1b30992b623e/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libcamera-0~git20211108+1b30992b623e/debian/patches/series 2022-10-10 10:23:29.000000000 +0200
@@ -0,0 +1 @@
+ppc64el-fix-ftbfs-gcc.patch
--- End Message ---
--- Begin Message ---
Source: libcamera
Source-Version: 0~git20211108+1b30992b623e-5
Done: Benjamin Drung <bdrung@debian.org>
We believe that the bug you reported is fixed in the latest version of
libcamera, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1021544@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Benjamin Drung <bdrung@debian.org> (supplier of updated libcamera package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 12 Oct 2022 11:43:40 +0200
Source: libcamera
Built-For-Profiles: noudeb
Architecture: source
Version: 0~git20211108+1b30992b623e-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Benjamin Drung <bdrung@debian.org>
Closes: 1021544
Launchpad-Bugs-Fixed: 1992331
Changes:
libcamera (0~git20211108+1b30992b623e-5) unstable; urgency=medium
.
* Team upload.
.
[ Olivier Gayot ]
* Add patch that fixes FTBFS on ppc64el + GCC (Closes: #1021544, LP: #1992331)
Checksums-Sha1:
3139369aaa9c9d535be268f7907a87fbfda238d3 2822 libcamera_0~git20211108+1b30992b623e-5.dsc
b8c7fb9b45ee84fd3384c89cad73535ccdb2139c 30300 libcamera_0~git20211108+1b30992b623e-5.debian.tar.xz
d596cbcca1fa02f0a69d41f27ea0462cb5f76323 8900 libcamera_0~git20211108+1b30992b623e-5_source.buildinfo
Checksums-Sha256:
e8abe363f46fce81521b76f4c67ba6c9bcfdcac026d4a16ad88cc2817793669a 2822 libcamera_0~git20211108+1b30992b623e-5.dsc
60cb33bee9c65aefc29768469f6f8594c8a521557ce2142783f8283d8cbb3148 30300 libcamera_0~git20211108+1b30992b623e-5.debian.tar.xz
8f1d46f82be374ba9430be5cd6d6f54bffbf54f79d1548818eb03b7732aa37e0 8900 libcamera_0~git20211108+1b30992b623e-5_source.buildinfo
Files:
263de3af3c6c6da907b33a8d7b74d001 2822 libs optional libcamera_0~git20211108+1b30992b623e-5.dsc
ac90cb18c09a636c449af00677f5a51d 30300 libs optional libcamera_0~git20211108+1b30992b623e-5.debian.tar.xz
0296b44417d81495539fa1c3d813bf27 8900 libs optional libcamera_0~git20211108+1b30992b623e-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEE5/q3CzlQJ15towl13YzVpd6MfnoFAmNGjiUSHGJkcnVuZ0Bk
ZWJpYW4ub3JnAAoJEN2M1aXejH56J6YQAIuz7ubMeMnszMNrBgVqvrDenUa8bKVT
HaKXAfaAuebbkAQxruEICPm3TkWoak+BM0GagzJ8c2F4zRTizP2ozUwBkvtqA80t
AY01HbzOPjc90CwxaaMVqR6DLgspK9uOWAMtySjVtybPbGgwSkCs1CfOB+t/hhss
wLuhkIYw+F9JiKPEbvcm3NPl0nhSrVLvi+CSAtL+g+jxTyvMh7+iGX7NLnWv3+vT
DtNhYEGVepZVFYmyrtpPH8X5sGm6iQV2lBkh2tDf8e/+qXIwvYDmMJb1B0w1TBKK
qp9YYsRYudaLQZERsZGv/kZBhtpdovYZ6+IJL+NOImQG1uUkcNWzc9p+A8V7Z4Q+
1KwXgxIP7PKw+QvmSXgFZ3skNKWzEgvrCzvqaRcy7wL0UGzcS38UJeOBcHElL4+N
FEd5iqc0cPu43MjeIT+xw5bP3ontdFAm3P0Sy90PZfJ2bzBADlHtIXw4NfjpXecA
5p9D7UadBHdl3ai1oG79fXkk5JzLrgedSmpRh2lwAWWRRj95lE1Mwt4mxJxrQ92G
eFDd1EBK07fYC8vCtJNA4+oxd7BF3A8RsWwEeMlTAI18/YVb4qDnYd6W88LlkRBH
V5/Xi/WYgMHvWkmeAlDHXAE5fXROM/07nDE4Dya9qutcA4NcAI4gY1iWfSAhq58Y
8qMDlD9wLmBV
=HpjF
-----END PGP SIGNATURE-----
--- End Message ---