[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#968508: blender-data: Please only recommend blender instead of python3



On Sun, Aug 16, 2020 at 05:47:17PM +0200, Elrond wrote:
> On Sun, Aug 16, 2020 at 17:35:32 +0200, Jonas Smedegaard wrote:
> > Quoting Elrond (2020-08-16 17:16:26)
> > > On the other hand, blender-data does not need to depend on python3. 
> > > Yes, there are some python scripts in there, but they do only make 
> > > sense together with blender.
> > 
> > If blender-data contains scripts which require Python3 to run, then it 
> > must declare either Depends or Recommends on python3.
> > 
> > 
> > > If you want to keep the python3 dep, please turn it into
> > > python3:any, and also into a Recommends. Recommends means
> > > "You really should install this. If you don't, expect
> > > missing functionality", which seems right then.
> > 
> > If those python3 scripts are not always used, then it makes sense to 
> > relax to only recommend python3.
> 
> TBH I am not 100% sure, if they're not always used. I might
> try sometime soon.

Either way, here is the problem:
the source control file has
    Package: blender-data
    Architecture: all
    Depends: python3,
             ${misc:Depends},
             ${python3:Depends}
Note how it also has ${python3:Depends}.  That substvar should be
expanded to "python3:any" (with an appropriate version restriction if
deemed needed by the tooling), and the helper that is supposed to fill
in that substvar is dh_python3.
dh_python3 is already called by the rules file, but the scripts are all
in private locations; dh_python3 doesn't look into private directories
that are not named after the binary package name, so it needs to be
instructed as such, by adding an override and pass the private dirs
(looking at the file list, I guess `/usr/share/blender/scripts/` is
enough, but should be tested) as arguments of dh_python3, and then
python3:any will be added to the python3:Depends substvar.  After that,
the explicit python3 dep can go away.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: