Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Hi Arto,
Arto Jantunen <viiru@debian.org> writes:
> Xiyue Deng <manphiz@gmail.com> writes:
>> Package: sponsorship-requests
>> Severity: important
>> X-Debbugs-CC: debian-emacsen@lists.debian.org
>>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "lsp-mode":
>>
>> * Package name : lsp-mode
>> Version : 8.0.0-6
>> Upstream contact : Vibhav Pant <vibhavp@gmail.com>
>> * URL : https://github.com/emacs-lsp/lsp-mode
>> * License : GPL-3+
>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>> Section : lisp
>>
>> The source builds the following binary packages:
>>
>> elpa-lsp-mode - Emacs client/library for the Language Server Protocol
>>
>> To access further information about this package, please visit the following URL:
>>
>> https://mentors.debian.net/package/lsp-mode/
>>
>> Alternatively, you can download the package with 'dget' using this command:
>>
>> dget -x https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>
>> Changes since the last upload:
>>
>> lsp-mode (8.0.0-6) unstable; urgency=medium
>> .
>> * Add patch to fix test failures (Closes: #1052939).
>> * Update Standards-Version to 4.6.2. No change needed.
>> * Add myself as uploader (Closes: #1042568).
>> * Add signing key verification to d/watch.
>> * Add d/upstream/metadata.
>> * Add Upstream-Contact and update year in d/copyright.
>> * Add patch to fix non-UTF-8 encoding.
>> * Drop unused lintian overrides.
>
> Thanks for taking over this package.
>
> When I try to build this (under sbuild) I get the following build
> failure:
>
> Test ‘lsp-text-document-hover-request’ redefined
>
> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
> mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x187de6214517952>))
> debug-early-backtrace()
> debug-early(error (error "Test ‘lsp-text-document-hover-request’ redefined"))
> error("Test `%s' redefined" lsp-text-document-hover-request)
> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
> lsp-text-document-hover-request :documentation nil :body (closure (t) nil
> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures")) (find-file
> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp) (deferred:sync!
> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq 'initialized
> (lsp--workspace-status (cl-first (lsp-workspaces)))))) #'(lambda (_) (goto-char
> (point-min)) (search-forward "fn1") (lsp-def-request-async "textDocument/hover"
> (lsp--text-document-position-params)))) #'(lambda (contents) (let* ((fn-566
> #'lsp-hover?) (args-567 (condition-case err (let ((signal-hook-function
> #'ert--should-signal-hook)) (list contents)) (error (progn (setq fn-566
> #'signal) (list (car err) (cdr err))))))) (let ((value-568
> 'ert-form-evaluation-aborted-569)) (let (form-description-570) (if
> (unwind-protect (setq value-568 (apply fn-566 args-567)) (setq
> form-description-570 (nconc (list '(should (lsp-hover? contents))) (list :form
> (cons fn-566 args-567)) (if (eql value-568 'ert-form-evaluation-aborted-569) nil
> (list :value value-568)) (if (eql value-568 'ert-form-evaluation-aborted-569)
> nil (let* ((-explainer- (and t (ert--get-explainer 'lsp-hover?)))) (if
> -explainer- (list :explanation (apply -explainer- args-567)) nil)))))
> (ert--signal-should-execution form-description-570)) nil (ert-fail
> form-description-570))) value-568))))) (kill-buffer)
> (lsp-workspace-folders-remove (f-join lsp-test-location "fixtures")))
> :most-recent-result nil :expected-result-type :passed :tags nil :file-name
> "/<<PKGBUILDDIR>>/test/lsp-integration-test.el"))
> load-with-code-conversion("/<<PKGBUILDDIR>>/test/lsp-integration-test.el" "/<<PKGBUILDDIR>>/test/lsp-integration-test.el" nil t)
> command-line-1(("-l" "package" "--eval" "(add-to-list 'package-directory-list
> \"/usr/share/emacs/site-lisp/elpa\")" "--eval" "(add-to-list
> 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" "-f"
> "package-initialize" "-L" "clients/" "-L" "." "-L" "test" "-l"
> "test/lsp-clangd-test.el" "-l" "test/lsp-completion-test.el" "-l"
> "test/lsp-file-watch-test.el" "-l" "test/lsp-integration-test.el" "-l"
> "test/lsp-io-test.el" "-l" "test/lsp-javascript-test.el" "-l"
> "test/lsp-methods-test.el" "-l" "test/lsp-mode-test.el" "-l"
> "test/lsp-protocol-test.el" "-l" "test/lsp-common-test.el" "-l"
> "debian/ert-helper.el"))
> command-line()
> normal-top-level()
> dh_elpa_test: error: emacs -batch -Q -l package --eval "(add-to-list
> 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval
> "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")"
> -f package-initialize -L clients/ -L . -L test -l test/lsp-clangd-test.el -l
> test/lsp-completion-test.el -l test/lsp-file-watch-test.el -l
> test/lsp-integration-test.el -l test/lsp-io-test.el -l
> test/lsp-javascript-test.el -l test/lsp-methods-test.el -l test/lsp-mode-test.el
> -l test/lsp-protocol-test.el -l test/lsp-common-test.el -l debian/ert-helper.el
> returned exit code 255
> make: *** [debian/rules:4: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
>
> Is this something specific to my environment? I can't see two actual
> definitions of a test with that name...
I tried downloading the dsc I uploaded to mentors and run sbuild on it
directly, but I cannot reproduce this issue after three tries.
Can you also try to reproduce using the team repo? It is just one
commit ("dch -r") away from the one on mentors.
--
Xiyue Deng
Reply to: