Re: RFS: trend
On Thu, Aug 13, 2009 at 6:43 PM, Yuri D'Elia<wavexx@users.sf.net> wrote:
> On Thu, 13 Aug 2009 13:00:04 +0800
> Paul Wise <pabs@debian.org> wrote:
>> IIRC debian policy recommends compiling with -Wall, but trend is not
>> compiled that way.
>
> Should I add these flags manually in debian/rules?
The usual way is to set CFLAGS in debian/rules and pass that to
./configure or make.
>> When I add -Wall and -Wextra I get these warnings from gcc (not sure
>> why trend.cc warnings are produced for color.cc):
> <...>
>
> Ah, sorry. I manually filtered those on my box and never used
> -Wall in debian/rules.
>
> The 'uninitialized' warnings, though, are bogus warnings in this case.
> Initializing them to any value would be just as bad, that's why I left
> them.
Why is that?
>> P: trend: no-upstream-changelog
>
> There is a NEWS file which summarizes all changes between releases.
> I kept a full-length ChangeLog (generated from the SCM) in the past,
> but that's noise from an user point of view.
I personally find ChangeLog files (generated from the SCM/VCS) useful
in addition to the NEWS file.
> I will implement all your suggestions. Should I generate and upload a
> new package into mentors with the same release number?
Great, yes.
>> It is fun to do cat /dev/urandom | trend, you might want to include
>> that in the examples in the manual page.
>
> Try this:
>
> vmstat 1 | sed -u -e 1,2d | trend -F -c16a "-L$(vmstat 1 | head -2 |
> tail -1 | sed -e 's/\([^ ]\) */\1,/g')" - 60x2
Nice.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: