[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFS: symlinks (updated package)



Dear mentors,

I am looking for a sponsor for the new version 1.2-6 of my package
"symlinks".

It builds this binary package:
symlinks   - scan/change symbolic links

Detailed description:

,----
|  Symlinks scans directories for symbolic links and lists them on
|  stdout. Each link is prefixed with a classification of relative,
|  absolute, dangling, messy, lengthy or other_fs.
|  
|  Symlinks can also convert absolute links (within the same filesystem)
|  to relative links and can delete messy and dangling links.
`----

There is one overridden lintian warning and two remarks shown at the
"pedantic" level.

The upload would fix bug 61140, a bug that is more than nine years old.
I have also switched to using quilt as a patch system; the attached diff
shows the changes against the previous version after the patches have
been applied.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/s/symlinks
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/symlinks/symlinks_1.2-6.dsc

I would be glad if someone uploaded this package for me.

Regards,
        Sven

Attachment: pgpKK8a8xXd6K.pgp
Description: PGP signature

Only in symlinks-1.2: .pc
Only in symlinks-1.2/debian: README.source
diff -ur symlinks-1.2.old/debian/changelog symlinks-1.2/debian/changelog
--- symlinks-1.2.old/debian/changelog	2009-07-22 16:58:13.000000000 +0200
+++ symlinks-1.2/debian/changelog	2009-07-22 16:58:27.000000000 +0200
@@ -1,3 +1,15 @@
+symlinks (1.2-6) unstable; urgency=low
+
+  * Use get_current_dir_name() instead of getcwd() to ensure correct
+    shortening if the path “symlinks” operates on contains itself a
+    symlink (Closes: #61140).  Thanks to Michael Schuerig.
+  * Use quilt as a patch system, add debian/README.source as
+    recommended by Policy §4.14.
+  * Bump Standards-Version to 3.8.2, no further changes needed.
+  * Add Vcs-Browser and Vcs-Git fields to debian/control.
+
+ -- Sven Joachim <svenjoac@gmx.de>  Sat, 18 Jul 2009 16:36:17 +0200
+
 symlinks (1.2-5) unstable; urgency=low
 
   * New maintainer (Closes: #486001).
diff -ur symlinks-1.2.old/debian/control symlinks-1.2/debian/control
--- symlinks-1.2.old/debian/control	2009-07-22 16:58:13.000000000 +0200
+++ symlinks-1.2/debian/control	2009-07-22 16:58:27.000000000 +0200
@@ -2,8 +2,10 @@
 Section: utils
 Priority: optional
 Maintainer: Sven Joachim <svenjoac@gmx.de>
-Build-Depends: debhelper (>= 7)
-Standards-Version: 3.8.0
+Build-Depends: debhelper (>= 7), quilt (>= 0.40)
+Standards-Version: 3.8.2
+Vcs-Browser: http://git.debian.org/?p=users/joachim-guest/symlinks.git
+Vcs-Git: git://git.debian.org/users/joachim-guest/symlinks.git
 
 Package: symlinks
 Architecture: any
Only in symlinks-1.2/debian: patches
diff -ur symlinks-1.2.old/debian/rules symlinks-1.2/debian/rules
--- symlinks-1.2.old/debian/rules	2009-07-22 16:58:13.000000000 +0200
+++ symlinks-1.2/debian/rules	2009-07-22 16:58:27.000000000 +0200
@@ -2,7 +2,9 @@
 
 # export DH_VERBOSE=1
 
-CFLAGS = -Wall -g
+include /usr/share/quilt/quilt.make
+
+CFLAGS = -Wall -g -D_GNU_SOURCE
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -O0
 else
@@ -11,12 +13,12 @@
 
 build: build-stamp
 
-build-stamp:
+build-stamp: patch
 	dh_testdir
 	$(MAKE) CFLAGS="$(CFLAGS)" prefix=/usr
 	touch $@
 
-clean:
+clean: unpatch
 	dh_testdir
 	$(MAKE) clean
 	dh_clean
@@ -44,4 +46,4 @@
 
 binary:	binary-indep binary-arch
 
-.PHONY: binary binary-arch binary-indep clean checkroot
+.PHONY: binary binary-arch binary-indep build clean patch unpatch
Only in symlinks-1.2/debian: stamp-patched
diff -ur symlinks-1.2.old/symlinks.c symlinks-1.2/symlinks.c
--- symlinks-1.2.old/symlinks.c	2009-07-22 16:58:13.000000000 +0200
+++ symlinks-1.2/symlinks.c	2009-07-22 16:58:56.503014120 +0200
@@ -303,7 +303,12 @@
 
 int main(int argc, char **argv)
 {
+#ifdef _GNU_SOURCE
+	static char path[PATH_MAX+2];
+	char* cwd = get_current_dir_name();
+#else
 	static char path[PATH_MAX+2], cwd[PATH_MAX+2];
+#endif
 	int dircount = 0;
 	char c, *p;
 
@@ -312,8 +317,13 @@
         else
                 progname++;
 
+#ifdef _GNU_SOURCE
+	if (NULL == cwd) {
+		fprintf(stderr,"get_current_dir_name() failed\n");
+#else
 	if (NULL == getcwd(cwd,PATH_MAX)) {
 		fprintf(stderr,"getcwd() failed\n");
+#endif
 		return (1);
 	}
 	if (!*cwd || cwd[strlen(cwd)-1] != '/')

Reply to: