[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.1.0-11-g8749adf



The following commit has been merged in the master branch:
commit 8749adf8d497ab13070fce7db6afa47263967b82
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date:   Mon Dec 1 23:55:25 2008 +0000

    Use blocking filehandles to pass filename lists to external processes.
    
    * collection/{fileinfo,md5sums}:
      + Use blocking filehandles to pass the list of filenames to check
        to the spawned file / md5sum.  By default the handles were non-blocking
        which could lead to problems with larger file lists.  (Closes: #507461)

diff --git a/collection/file-info b/collection/file-info
index e50a58a..59702bd 100755
--- a/collection/file-info
+++ b/collection/file-info
@@ -41,6 +41,7 @@ my %opts = ( pipe_in => FileHandle->new,
 	     out => '../file-info',
 	     fail => 'error' );
 spawn(\%opts, ['xargs', '-0r', 'file']);
+$opts{pipe_in}->blocking(1);
 open(INDEX, '<', "../index")
     or fail("cannot open index file: $!");
 while (<INDEX>) {
diff --git a/collection/md5sums b/collection/md5sums
index f4e9339..4a3af6f 100755
--- a/collection/md5sums
+++ b/collection/md5sums
@@ -40,6 +40,7 @@ my %opts = ( pipe_in => FileHandle->new,
 	     out => '../md5sums',
 	     fail => 'error' );
 spawn(\%opts, ['xargs', '-0r', 'md5sum'] );
+$opts{pipe_in}->blocking(1);
 open(INDEX, '<', "../index")
     or fail("cannot open index file: $!");
 while (<INDEX>) {
diff --git a/debian/changelog b/debian/changelog
index 3e8df01..eb8db24 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,11 @@ lintian (2.1.1) unstable; urgency=low
       better match executions of the command rather than the use of its name
       in pattern matching expressions.  (Closes: #499847)
 
+  * collection/{fileinfo,md5sums}:
+    + [ADB] Use blocking filehandles to pass the list of filenames to check
+      to the spawned file / md5sum.  By default the handles were non-blocking
+      which could lead to problems with larger file lists.  (Closes: #507461)
+
   * lib/Lintian/Output.pm:
     + [ADB] Make sure the default list of colours is initialised before
       attempting to use it.  Thanks, gregor herrmann.  (Closes: #507241)

-- 
Debian package checker


Reply to: