[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://iptables-persistent/{iptables-persistent.templates}



Quoting Jonathan Wiltshire (jmw@debian.org):
> Please find, for review, the debconf templates of iptables-persistent.
> 
> This review will last from Monday, January 03, 2011 to Thursday, January 13, 2011.
> 
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.


Here they are.

--- iptables-persistent.templates	2011-01-04 06:44:35.779588744 +0100
+++ iptables-persistent.templates.bubulle	2011-01-04 06:50:21.738988464 +0100
@@ -2,7 +2,7 @@
 Type: boolean
 Default: false
 _Description: Save current IPv4 rules?
- The installer can save your current iptables rules to the configuration
+ Current iptables rules can be saved to the configuration
  file /etc/iptables/rules.v4. These rules will then be loaded next time
  the machine is started.
  .
@@ -14,7 +14,7 @@
 Type: boolean
 Default: false
 _Description: Save current IPv6 rules?
- The installer can save your current iptables rules to the configuration
+ Current iptables rules can be saved to the configuration
  file /etc/iptables/rules.v6. These rules will then be loaded next time
  the machine is started.
  .


The point, here, is to avoid "the installer" as there is, strictly
speaking, no installer.


--- control	2011-01-04 06:46:06.315004391 +0100
+++ control.bubulle	2011-01-04 06:47:12.179048425 +0100
@@ -10,9 +10,9 @@
 Package: iptables-persistent
 Architecture: all
 Depends: iptables, lsb-base, ${misc:Depends}
-Description: simple package to set up iptables on boot
- This package just contains a system startup script that restores iptables
+Description: set up iptables on boot
+ This package provides a system startup script that restores iptables
  rules from a configuration file.
  .
- Since this is aimed at experienced adminstrators, there is no configuration
+ Since this is aimed at experienced administrators, there is no configuration
  wizard.


Drop suggestion that the package is "simple" and "just" provides
stuff. After all, who knows? You could maybe slowly enhance it and
make it a very powerful tool..:-)


--- iptables-persistent.templates	2011-01-04 06:44:35.779588744 +0100
+++ iptables-persistent.templates.bubulle	2011-01-04 06:50:21.738988464 +0100
@@ -2,7 +2,7 @@
 Type: boolean
 Default: false
 _Description: Save current IPv4 rules?
- The installer can save your current iptables rules to the configuration
+ Current iptables rules can be saved to the configuration
  file /etc/iptables/rules.v4. These rules will then be loaded next time
  the machine is started.
  .
@@ -14,7 +14,7 @@
 Type: boolean
 Default: false
 _Description: Save current IPv6 rules?
- The installer can save your current iptables rules to the configuration
+ Current iptables rules can be saved to the configuration
  file /etc/iptables/rules.v6. These rules will then be loaded next time
  the machine is started.
  .
--- control	2011-01-04 06:46:06.315004391 +0100
+++ control.bubulle	2011-01-04 06:47:12.179048425 +0100
@@ -10,9 +10,9 @@
 Package: iptables-persistent
 Architecture: all
 Depends: iptables, lsb-base, ${misc:Depends}
-Description: simple package to set up iptables on boot
- This package just contains a system startup script that restores iptables
+Description: set up iptables on boot
+ This package provides a system startup script that restores iptables
  rules from a configuration file.
  .
- Since this is aimed at experienced adminstrators, there is no configuration
+ Since this is aimed at experienced administrators, there is no configuration
  wizard.

Attachment: signature.asc
Description: Digital signature


Reply to: