Re: [RFR] templates://sysvinit/{sysv-rc.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
I've added a couple of control-file changes, but the patch doesn't
mention the added file.
> Template: sysv-rc/convert-legacy
> + The boot system is prepared to migrate to dependency-based sequencing.
> .
> + A full rationale for this migration is detailed in
> + /usr/share/doc/sysvinit/README.Debian. This migration process is
> + non-reversible.
Well, fair enough. (Is it big enough that it'll automatically be
gzipped?)
> + If you don't choose to migrate now, you can do it later by running
> + "dpkg-reconfigure sysv-rc".
Or:
If you choose not to migrate now, you can do so later by running
"dpkg-reconfigure sysv-rc".
> Template: sysv-rc/unable-to-convert
[...]
> + If the reported problem is a local modification, it needs to be fixed
> + manually. If it's a bug in the package, it should be reported to the
^
Inconsistent inter-sentence spacing.
In the README:
> Migrating to dependency-based boot sequencing
> ---------------------------------------------
>
> It is recommended to migrate for the following reasons:
I'd keep this passive but avoid the impersonal construction:
Migrating is recommended for the following reasons:
> - the order of boot and shutdown is calculated dynamically, using
> dependency information declared within each init.d script, which
> ensures optimum and correct boot sequence for the set of installed
> packages;
"Calculated dynamically" makes it sound as if it means the system
will decide on the best ordering _while_ it's booting. And what
does "optimum and correct" mean? I think I'd rephrase it as:
* boot and shutdown ordering is calculated on the basis of the
dependency information declared within each init.d script, ensuring
that the sequence is optimized for the set of packages installed;
This is a full sentence; the next one's a noun phrase, then a verb
phrase, then a noun phrase.
> - protection against problems introduced by new or upgraded packages
> by preserving the boot sequence when problems are detected; the boot
> sequence is only modified if it is safe to do so;
This sounds less like an advantage of dep-based-boot and more like a
mitigation of its dangers. Phrase it more positively (and as a
sentence):
* problems introduced by new or upgraded packages can be detected and
averted - the boot sequence is only modified if it is safe to do so;
> - potential for further optimization by way of concurrent boot
> methodology in order to increase boot efficiency;
A particularly clotted noun phrase, which makes it sound as if it's
a "potential" advantage that we might get in Squeeze+n, but as I
understand it it's being wheeled out as officially ready for use
now. Good thing too, because I've been using it for ages.
* initscripts can be made to run more efficiently via parallelized
execution strategies.
> - fixes long standing issues with the legacy, static priority based
> boot ordering.
This is a cop-out, and an unconvincing one to end on. If the old
system had "issues", name them - or better yet, phrase them as
positive features of the new system! Unfortunately, all the other
advantages I can think of are in terms of inter-package coordination
difficulties for Debian developers, not for end-users. I've just
dropped this bulletpoint from my version.
(Maybe the idea that dynamic ordering fits better with the way 2.6
kernels probe hardware...?)
> This migration process is non-reversible. The legacy way of ordering
> boot scripts using static sequence numbers will be made obsolete by
> choosing to migrate. Any boot sequence changes done locally will be
^
> lost and have to redone using dependencies.
^be
>
> See http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for
> more information about dependency based boot sequencing.
-based
Then in the control file (I've mumbled about it before, without
quite getting to the point of bothering to make it a bugreort -
http://lists.debian.org/debian-l10n-english/2008/06/msg00006.html):
> Package: sysvinit-utils
[...]
> Specifically, this package includes:
> killall5, last, lastb, mesg, pidof, service, sulogin
Oh, "/usr/sbin/service", time for me to retire my bash-alias of that
name! This package description is one of the ones that wishes it
could just say ${DHCONTENTS} or something and let debhelper expand
it appropriately...
> Package: sysv-rc
> This package provides support for the System-V like system
> for booting, shutting down and changing runlevels,
> configured through symbolic links in /etc/rc?.d/.
Alphabetical and dependency-based sequencing would both say:
for booting, changing runlevels, and shutting down,
> Package: initscripts
[...]
> The scripts in this package initialize a standard Debian
> GNU/Linux system at boot time and shut it down at halt or
> reboot time.
Drop the "GNU/Linux" there, now that this text is in the package
description for initscripts_2.87dsf-4_kfreebsd-i386.deb!
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru sysvinit.old/debian/sysv-rc.templates sysvinit/debian/sysv-rc.templates
--- sysvinit.old/debian/sysv-rc.templates 2009-09-08 08:14:49.000000000 +0100
+++ sysvinit/debian/sysv-rc.templates 2009-09-12 18:46:48.000000000 +0100
@@ -10,52 +10,30 @@
Template: sysv-rc/convert-legacy
Type: boolean
Default: true
-Description: Migrate legacy boot sequencing to dependency based sequencing?
- The boot system is prepared to migrate to dependency based sequencing.
- It is recommended to migrate for the following reasons:
+Description: Migrate legacy boot sequencing to dependency-based sequencing?
+ The boot system is prepared to migrate to dependency-based sequencing.
.
- * the order of boot and shutdown is calculated dynamically, using
- dependency information declared within each init.d script, which
- ensures optimum and correct boot sequence for the set of installed
- packages
- * protection against problems introduced by new or upgraded packages
- by preserving the boot sequence when problems are detected; the boot
- sequence is only modified if it is safe to do so
- * potential for further optimization by way of concurrent boot
- methodology in order to increase boot efficiency
- * fixes long standing issues with the legacy, static priority based
- boot ordering.
+ A full rationale for this migration is detailed in
+ /usr/share/doc/sysvinit/README.Debian. This migration process is
+ non-reversible.
.
- This migration process is non-reversible. The legacy way of ordering
- boot scripts using static sequence numbers will be made obsolete by
- choosing to migrate. Any boot sequence changes done locally will be
- lost and have to redone using dependencies.
- .
- See http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for
- more information about dependency based boot sequencing. To
- reattempt the migration process run 'dpkg-reconfigure sysv-rc'.
+ If you choose not to migrate now, you can do so later by running
+ "dpkg-reconfigure sysv-rc".
Template: sysv-rc/unable-to-convert
Type: note
-Description: Unable to migrate to dependency based boot system
+#flag:translate!:3
+Description: Unable to migrate to dependency-based boot system
Tests have determined that problems in the boot system exist which
- prevent migration to dependency based boot sequencing. It is
- recommended to migrate for the following reasons:
+ prevent migration to dependency-based boot sequencing:
.
- * the order of boot and shutdown is calculated dynamically, using
- dependency information declared within each init.d script, which
- ensures optimum and correct boot sequence for the set of installed
- packages
- * protection against problems introduced by new or upgraded packages
- by preserving the boot sequence when problems are detected; the boot
- sequence is only modified if it is safe to do so
+ ${PROBLEMATIC}
.
- If the reported problem is a local modification it needs to be fixed
- manually. If it's a bug in the package it should be reported to the
+ If the reported problem is a local modification, it needs to be fixed
+ manually. If it's a bug in the package, it should be reported to the
BTS and fixed in the package. See
http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for more
- information about how to fix the problems preventing migration. To
- reattempt the migration process after the problems have been fixed,
- run 'dpkg-reconfigure sysv-rc'.
+ information about how to fix the problems preventing migration.
.
- The following problems were detected: ${PROBLEMATIC}
+ To reattempt the migration process after the problems have been
+ fixed, run "dpkg-reconfigure sysv-rc".
diff -ru sysvinit.old/debian/control sysvinit/debian/control
--- sysvinit.old/debian/control 2009-09-08 08:14:51.000000000 +0100
+++ sysvinit/debian/control 2009-09-12 18:22:04.000000000 +0100
@@ -46,7 +46,7 @@
Breaks: initscripts (<< 2.86.ds1-63)
Description: System-V-like runlevel change mechanism
This package provides support for the System-V like system
- for booting, shutting down and changing runlevels,
+ for booting, changing runlevels, and shutting down,
configured through symbolic links in /etc/rc?.d/.
Package: initscripts
@@ -57,6 +57,4 @@
Replaces: libc6, libc6.1, libc0.1, libc0.3
Description: scripts for initializing and shutting down the system
The scripts in this package initialize a standard Debian
- GNU/Linux system at boot time and shut it down at halt or
- reboot time.
-
+ system at boot time and shut it down at halt or reboot time.
# These templates have not been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.
Template: sysv-rc/convert-legacy
Type: boolean
Default: true
Description: Migrate legacy boot sequencing to dependency-based sequencing?
The boot system is prepared to migrate to dependency-based sequencing.
.
A full rationale for this migration is detailed in
/usr/share/doc/sysvinit/README.Debian. This migration process is
non-reversible.
.
If you choose not to migrate now, you can do so later by running
"dpkg-reconfigure sysv-rc".
Template: sysv-rc/unable-to-convert
Type: note
#flag:translate!:3
Description: Unable to migrate to dependency-based boot system
Tests have determined that problems in the boot system exist which
prevent migration to dependency-based boot sequencing:
.
${PROBLEMATIC}
.
If the reported problem is a local modification, it needs to be fixed
manually. If it's a bug in the package, it should be reported to the
BTS and fixed in the package. See
http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for more
information about how to fix the problems preventing migration.
.
To reattempt the migration process after the problems have been
fixed, run "dpkg-reconfigure sysv-rc".
Migrating to dependency-based boot sequencing
---------------------------------------------
Migrating is recommended for the following reasons:
* boot and shutdown ordering is calculated on the basis of the
dependency information declared within each init.d script, ensuring
that the sequence is optimized for the set of packages installed;
* problems introduced by new or upgraded packages can be detected and
averted - the boot sequence is only modified if it is safe to do so;
* initscripts can be made to run more efficiently via parallelized
execution strategies.
This migration process is non-reversible. The legacy way of ordering
boot scripts using static sequence numbers will be made obsolete by
choosing to migrate. Any boot sequence changes done locally will be
lost and have to be redone using dependencies.
See http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for
more information about dependency-based boot sequencing.
Source: sysvinit
Section: admin
Priority: required
Maintainer: Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>
Uploaders: Petter Reinholdtsen <pere@debian.org>, Henrique de Moraes Holschuh <hmh@debian.org>, Kel Modderman <kel@otaku42.de>
Build-Depends: debhelper (>= 1), po-debconf, quilt (>= 0.40), libselinux1-dev (>= 1.14) [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64], libsepol1-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64]
Standards-Version: 3.8.3
Homepage: http://freshmeat.net/projects/sysvinit/
Vcs-Svn: svn://svn.debian.org/pkg-sysvinit/sysvinit/trunk
Vcs-Browser: http://svn.debian.org/wsvn/pkg-sysvinit/sysvinit/trunk/
Package: sysvinit
Essential: yes
Architecture: any
Pre-Depends: initscripts, sysv-rc | file-rc, sysvinit-utils
Depends: ${shlibs:Depends}
Description: System-V-like init utilities
This package contains programs required for booting
a Debian system and doing basic process management.
.
The most important program in the package is /sbin/init.
It is the first process started on boot and continues
to run as process number 1 until the system halts. All
other processes are descended from it.
Package: sysvinit-utils
Essential: yes
Architecture: any
Conflicts: last, sysvconfig, chkconfig (<< 11.0-79.1-2)
Replaces: last, sysvinit (<= 2.86.ds1-65)
Depends: ${shlibs:Depends}
Suggests: sash
Description: System-V-like utilities
This package contains the important System-V-like utilities.
.
Specifically, this package includes:
killall5, last, lastb, mesg, pidof, service, sulogin
Package: sysv-rc
Architecture: all
Recommends: lsb-base (>= 3.0-6)
Conflicts: file-rc
Replaces: file-rc
Suggests: sysv-rc-conf, bum
Depends: debconf | debconf-2.0, sysvinit-utils (>= 2.86.ds1-62), insserv (>> 1.12.0-10)
Breaks: initscripts (<< 2.86.ds1-63)
Description: System-V-like runlevel change mechanism
This package provides support for the System-V like system
for booting, changing runlevels, and shutting down,
configured through symbolic links in /etc/rc?.d/.
Package: initscripts
Architecture: any
Depends: ${shlibs:Depends}, ${glibc:Depends}, ${mount:Depends}, debianutils (>= 2.13.1), lsb-base (>= 3.0-6), sysvinit-utils (>= 2.86.ds1-39), sysv-rc | file-rc
Recommends: psmisc, e2fsprogs
Conflicts: libdevmapper1.02.1 (<< 2:1.02.24-1)
Replaces: libc6, libc6.1, libc0.1, libc0.3
Description: scripts for initializing and shutting down the system
The scripts in this package initialize a standard Debian
system at boot time and shut it down at halt or reboot time.
Reply to: