[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640



Hi Ben,

On Thu, Dec 14, 2023 at 09:16:48AM +0000, Ben Mesman | Spark Narrowcasting wrote:
> The attached patch works on my systems. Is there a way to get this in?

> --- arch/x86/kernel/reboot.c.orig	2023-12-14 08:25:10.033382061 +0100
> +++ arch/x86/kernel/reboot.c	2023-12-14 08:31:10.394325941 +0100
> @@ -469,6 +469,14 @@
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
>  		},
>  	},
> +	{	/* Handle problems with rebooting HP t640 thin-clients */
> +		.callback = set_pci_reboot,
> +		.ident = "HP t640",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "HP t640 Thin Client"),
> +		},
> +	},
>  
>  	{	/* PCIe Wifi card isn't detected after reboot otherwise */
>  		.callback = set_pci_reboot,

We cannot pick changes which are not going to land in Linux upstream
and then backported to the stable series. So the way to go here is to
report the bug upstream, along with your proposed change. Candidates
to reach out are:

./scripts/get_maintainer.pl arch/x86/kernel/reboot.c
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),commit_signer:2/11=18%)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Borislav Petkov <bp@alien8.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Dave Hansen <dave.hansen@linux.intel.com> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
"H. Peter Anvin" <hpa@zytor.com> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Sean Christopherson <seanjc@google.com> (commit_signer:10/11=91%,authored:10/11=91%,added_lines:176/177=99%,removed_lines:102/103=99%)
Kai Huang <kai.huang@intel.com> (commit_signer:7/11=64%)
Josh Poimboeuf <jpoimboe@kernel.org> (commit_signer:1/11=9%,authored:1/11=9%)
"Peter Zijlstra (Intel)" <peterz@infradead.org> (commit_signer:1/11=9%)
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT))

as it is affecting 6.1.y mention that the fix needs to be backported to various
stable series at least back 6.1.y and describe which testing you have
performed.

Feel free to keep as well the Debian bug in the loop for the report.

Hope this helps?

Regards,
Salvatore


Reply to: