Bug#1040245: wget-style scroll bars in syslog after Debian 11->12 upgrade
Package: fwupd
Version: 1.8.12-2
Severity: minor
On Debian 11, I saw this:
$ journalctl --output=short-iso --identifier=fwupdmgr
⋮
2022-06-06T01:05:08+1000 hera fwupdmgr[906504]: Updating lvfs
2022-06-06T01:05:08+1000 hera fwupdmgr[906504]: Successfully downloaded new metadata: 6 local devices supported
2022-06-06T17:07:50+1000 hera fwupdmgr[1017291]: Updating lvfs
2022-06-06T17:07:51+1000 hera fwupdmgr[1017291]: Successfully downloaded new metadata: 6 local devices supported
2022-06-07T19:33:37+1000 hera fwupdmgr[1835934]: Updating lvfs
2022-06-07T19:33:38+1000 hera fwupdmgr[1835934]: Successfully downloaded new metadata: 3 local devices supported
2022-06-09T04:42:10+1000 hera fwupdmgr[2580402]: Updating lvfs
2022-06-09T04:42:11+1000 hera fwupdmgr[2580402]: Successfully downloaded new metadata: 3 local devices supported
⋮
On Debian 12, I see this:
$ journalctl --output=short-iso --identifier=fwupdmgr
⋮
2023-06-16T21:38:04+1000 hera fwupdmgr[471940]: Updating lvfs
2023-06-16T21:38:04+1000 hera fwupdmgr[471940]: Downloading… [ - ]Downloading… [ - ]
2023-06-17T21:31:45+1000 hera fwupdmgr[897912]: Updating lvfs
2023-06-17T21:31:45+1000 hera fwupdmgr[897912]: Downloading… [ - ]Downloading… [ - ]
2023-06-18T06:47:35+1000 hera fwupdmgr[1375535]: Updating lvfs
2023-06-18T06:47:36+1000 hera fwupdmgr[1375535]: Downloading… [ - ]Downloading… [ - ]Downloading… [ - ]Downloading… [ - ]Downloading… [ \ ]Downloading… [***************************************]Downloading… [***************************************]Downloading… [ \ ]Downloading… [******** ]Downloading… [******************* ]Downloading… [****************************** ]
2023-06-18T06:47:36+1000 hera fwupdmgr[1375535]: Successfully downloaded new metadata: 5 local devices supported
⋮
Can you please fix fwupd so the progress bar isn't logged to syslog?
If it just said "Downloading… done." or something, that would be OK.
It's the assumption that \r will erase the previous progress bar that's annoying -- syslog isn't a tty.
(These events also show up in logcheck emails.)
PS: I think the "Downloading" string is from https://salsa.debian.org/efi-team/fwupd/-/blob/debian/src/fu-console.c#L370
It seems like there's already an "isatty(1)" here: https://salsa.debian.org/efi-team/fwupd/-/blob/debian/src/fu-console.c#L91
I don't know why it isn't working properly anymore. Maybe the change was in systemd's unit semantics, instead of fwupd?
-- System Information:
Debian Release: 12.0
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'proposed-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-9-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages fwupd depends on:
ii adduser 3.134
ii libarchive13 3.6.2-1
ii libc6 2.36-9
ii libcbor0.8 0.8.0-2+b1
ii libcurl3-gnutls 7.88.1-10
ii libefiboot1 37-6
ii libflashrom1 1.3.0-2.1
ii libfwupd2 1.8.12-2
ii libgcab-1.0-0 1.5-1
ii libglib2.0-0 2.74.6-2
ii libgnutls30 3.7.9-2
ii libgudev-1.0-0 237-2
ii libgusb2 0.3.10-1
ii libjcat1 0.1.9-1
ii libjson-glib-1.0-0 1.6.6-1
ii liblzma5 5.4.1-0.2
ii libmbim-glib4 1.28.2-1
ii libmbim-proxy 1.28.2-1
ii libmm-glib0 1.20.4-1
ii libpolkit-gobject-1-0 122-3
ii libprotobuf-c1 1.4.1-1+b1
ii libqmi-glib5 1.32.2-1
ii libqmi-proxy 1.32.2-1
ii libsmbios-c2 2.4.3-1
ii libsqlite3-0 3.40.1-2
ii libsystemd0 252.6-1
ii libtss2-esys-3.0.2-0 3.2.1-3
ii libxmlb2 0.3.10-2
ii shared-mime-info 2.2-1
Versions of packages fwupd recommends:
ii bolt 0.9.5-1
ii dbus 1.14.6-1
ii fwupd-amd64-signed [fwupd-signed] 1:1.4+1
ii jq 1.6-2.1
ii python3 3.11.2-1+b1
pn secureboot-db <none>
ii udisks2 2.9.4-4
Versions of packages fwupd suggests:
pn gir1.2-fwupd-2.0 <none>
-- Configuration Files:
/etc/fwupd/redfish.conf [Errno 13] Permission denied: '/etc/fwupd/redfish.conf'
-- no debconf information
Reply to: