Il 14/06/2023 16:46, Michael Catanzaro ha scritto:
Thanks for report, I hadn't fully test soup3 porting but only build, install of package and one fast check to one thing that should use libtimezonemap before the upload to experimental.Package: libtimezonemap1 Version: 0.4.6-5 X-Debbugs-CC: itzswirlz2020@outlook.comHi maintainers, somebody noticed that you had ported libtimezonemap to libsoup 3 and I was asked to look into whether the patch would be good for Fedora or upstream. I noticed several problems. (1) The patch casts a const char* to a GUri*. That's not going to work. (2) It also frees a GAsyncResult using an incorrect free function, g_free() when it should be g_object_unref(). (3) It casts a SoupMessage to a SoupSession, which won't work. (4) The call to soup_session_get_async_result_message() looks like it wouldn't do anything even if it was called with a SoupSession rather than a SoupMessage.I'm excited to see more libsoup 3 porting, but I recommend dropping this patch. I see it has not yet graduated from experimental to sid, so that's good.
I can't try to fix the soup3 patch soon so I'll drop it for now for do an upload to unstable with crash fix for glib 2.76 before its migration to unstable.
If Joshua or somebody will do a fixed patch for soup3 I'll do another upload to experimental.
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature