Bug#1007929: netcfg: FTBFS on s390x

[Samuel Thibault <sthibault@debian.org>]

Control: tags -1 + pending

> Samuel Thibault <sthibault@debian.org> wrote (Sun, 20 Mar 2022 01:01:07 +0100):
> > Cyril Brulebois, le sam. 19 mars 2022 16:32:06 +0100, a ecrit:
> > > > Running suite(s): inet_mton
> > > > 95%: Checks: 24, Failures: 1, Errors: 0
> > > > test/test_netcfg_gateway_reachable.c:94:F:netcfg_gateway_reachable:test_netcfg_gateway_reachable_v6_fe80:0: Gateway erroneously unreachable
> > > > make[1]: *** [test/tests.mk:19: test] Error 1
> > > > make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> > > > dh_auto_test: error: make -j1 test returned exit code 2
> > > > make: *** [debian/rules:6: build-arch] Error 25
> > > 
> > > Paging Samuel & Igor, hunch says this might be related:
> > > 
> > >     commit 3549f77c39c06e7dfcfd59fce01ff2d4a0622058
> > >     Merge: 90e52aed 6bff2dee
> > >     Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > >     Date:   Sun Sep 5 14:59:46 2021 +0000
> > >     
> > >         Merge branch 'ipv6-link-local-gateway' into 'master'
> > >         
> > >         Add support for fe80::/10 addresses as IPv6 gateway, closes #901255
> > >         
> > >         See merge request installer-team/netcfg!3
> > 
> > I committed
> > 
> > -        if ((ntohs(gw_addr.in6.s6_addr32[0]) & 0xffc0) == (0xfe80 & 0xffc0)) {
> > +        if ((ntohl(gw_addr.in6.s6_addr32[0]) & 0xffc0) == (0xfe80 & 0xffc0)) {
> > 
> > which is required for the test to work at all indeed.  I guess that'll
> > just fix the issue.
> 
> I intended to upload netcfg, but build still fails, apparently with the same 
> error:

Oh, now I see it: it was indeed intended to be a ntohs since it's a
16bit value which it was compared to. It's the field name that was
bogus, now fixed.

Samuel