[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#928995: debian-installer: gen-hd-image: Start default partition size at 4MB.



Package: debian-installer
Severity: normal
Tags: patch
X-Debbugs-Cc: debian-arm@lists.debian.org

Some boot firmware, such as u-boot am335x_evm, have grown large enough
that it may overwrite the start of the first partition when configured
to start at 1MB.

We do not yet support targets affected by this, (e.g. am335x_evm), but
with this patch it would be trivial to add, or at least allow people to
use the firmware.none.img.gz + partition.img.gz and install u-boot
themselves.

Starting at an offset of 4MB will give plenty of room for feature
bloat... er... growth, and also better aligns with default size for page
erases on some media as a minor side benefit.

Currently, only images generated on armhf and arm64 would be affected.


A way to also set the default partition start in "partman" may be needed
as well at some point, in case someone installing with debian-installer
wants to use the boot media for the OS installation.

For now, at least making the boot media start at the 4MB offset will be
a start.


One-line patch attached! :)


live well,
  vagrant

From a05f428d987fadad1c2a1602d75245b42d6df89f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Tue, 14 May 2019 12:25:54 -0700
Subject: [PATCH] build/util/gen-hd-image: Start partition offset at 4MB to
 allow more room for boot firmware.

Boot firmware such as u-boot am335x_evm are installed at an offset
before the first partition, but has grown large enough to overlap and
thus overwrite the default 1MB partition offset.
---
 build/util/gen-hd-image | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/util/gen-hd-image b/build/util/gen-hd-image
index 52697bec7..4a70ee2bd 100755
--- a/build/util/gen-hd-image
+++ b/build/util/gen-hd-image
@@ -63,7 +63,7 @@ PARTID="0x0c"
 FATSIZE="32"
 BUILDTYPE="complete"
 SOURCEDIR="."
-PARTOFFSET="2048"
+PARTOFFSET="8192"
 DEFAULT_IMAGESIZE="976560" # default d-i FLOPPY_SIZE for hd-media images
 IMAGESIZE="${DEFAULT_IMAGESIZE}"
 COMPRESS="none"
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


Reply to: