Re: first package questions (salsa repo in personal or team, debian/control maintainers, expected failing unit tests)

[Carles Pina i Estany <carles@pina.cat>]

Hi,

On 05 Oct 2023 at 16:38:29, Andrey Rakhmatullin wrote:
> On Wed, Oct 04, 2023 at 07:58:11AM +0100, Carles Pina i Estany wrote:
> > Recap: pytest executed from "pybuild-autopkgtest", in the
> > python-cloudscraper package, would use the src cloudscrapper instead of
> > the installed one.
> > 
> > So, to make sure that pytest uses the installed one, I added in
> > debian/rules:
> > 
> > -----
> > before-pybuild-autopkgtest:
> > 	mv cloudscraper $(AUTOPKGTEST_TMP)
> > 
> > after-pybuild-autopkgtest:
> > 	mv $(AUTOPKGTEST_TMP) cloudscraper
> This looks very wrong, assuming it even runs.

Well, luckily $(AUTOPKGTEST_TMP) has no spaces :-) (I'll add " ")

Besides the lack of quotes: why does it look wrong? It's documented (or
this is how I understood it) in pybuild-autopkgtest(1), and it's
implemented in /usr/bin/pybuild-autopkgtest:
-------
    $ENV{PYBUILD_AUTOPKGTEST} = "1";
    if (system("grep -q ^before-pybuild-autopkgtest: debian/rules") == 0) {
        doit($run, "before-pybuild-autopkgtest");
    }
    doit($run, "pybuild-autopkgtest");
    if (system("grep -q ^after-pybuild-autopkgtest: debian/rules") == 0) {
        doit($run, "after-pybuild-autopkgtest");
    }
-------

Thanks!

-- 
Carles Pina i Estany
https://carles.pina.cat